DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5655E384240C
Subject: Re: Cygwin package search and cygcheck -p urlencoding still broken on
 new web server
To: The Cygwin Mailing List <cygwin@cygwin.com>
References: <f78e2eaf-07d6-a9bd-ee84-e6414131b23b@gmail.com>
 <9c03bed5-da26-512c-3c31-ed6cd59f8043@SystematicSw.ab.ca>
 <f6e7d3b9-eef8-5991-59f8-905db3a8fc53@gmail.com>
From: Jon Turney <jon.turney@dronecode.org.uk>
Message-ID: <acc98a4e-68e5-d70e-6271-50c6f0dfb364@dronecode.org.uk>
Date: Thu, 16 Jul 2020 14:42:44 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <f6e7d3b9-eef8-5991-59f8-905db3a8fc53@gmail.com>
Content-Language: en-GB
Precedence: list
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Errors-To: cygwin-bounces@cygwin.com
Sender: "Cygwin" <cygwin-bounces@cygwin.com>
Content-Transfer-Encoding: 8bit

On 16/07/2020 08:44, Marco Atzeri via Cygwin wrote:
> On 16.07.2020 06:25, Brian Inglis wrote:
>> On 2020-07-15 14:13, Marco Atzeri via Cygwin wrote:
>>> Problem: I want to search for
>>>     libssh/libssh.h
>>> Using https://cygwin.com/packages/
>>> If I put the name and press Go the URL is changed in
>>> https://cygwin.com/cgi-bin2/package-grep.cgi?grep=libssh%2Flibssh.h&arch=x86_64 
>>>
>>> and the output is
>>>     Found 0 matches for libsshx2Flibssh.h
>>>                               ^^^
>>> Instead if I modify directly the URL in:
>>> https://cygwin.com/cgi-bin2/package-grep.cgi?grep=libssh/libssh.h&arch=x86_64 

I think that this is an invalid URL, that just happens to work, so it's 
correct that the link we produce is urlencoded.

(See e.g. https://en.wikipedia.org/wiki/Query_string#URL_encoding)

>>> Found 3 matches for libssh/libssh.h
>>> ....
>>> I guess that the current incapability is due to spurious urlencode in
>>> cgi-bin2/package-grep.cgi
>>> that is modifing the $param_grep
>>> echo '<li><a href="package-cat.cgi?file='`urlencode
>>> $partfile`'&amp;grep='`urlencode $param_grep`'">'$file'</a> - 
>>> '$desc'</li>'
>>> Could someone double check my guess ?

So it seems the urlencode is correct, but the urldecode isn't working.

I've applied a one-character change which appears to fix things.

> the git logs says that only Frank and Jon have recently worked on
> 
>     cgi-bin2/package-grep.cgi
> 
> I would like to double check any possible modification before proposing a
> patch to change the web server...

This was actually fairly easy to reproduce locally, once I realized what 
was going on:

$ export url="libssh%2Flibssh.h" ; printf '%b' "${url//%/\x}"
libsshx2Flibssh.h

$ export url="libssh%2Flibssh.h" ; printf '%b' "${ur//%/\\x}"
libssh/libssh.h
--
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple