DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 60B92385700A
Subject: Re: Cygwin package search and cygcheck -p urlencoding still broken on
 new web server
To: cygwin@cygwin.com
References: <f78e2eaf-07d6-a9bd-ee84-e6414131b23b@gmail.com>
 <9c03bed5-da26-512c-3c31-ed6cd59f8043@SystematicSw.ab.ca>
Message-ID: <f6e7d3b9-eef8-5991-59f8-905db3a8fc53@gmail.com>
Date: Thu, 16 Jul 2020 09:44:33 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <9c03bed5-da26-512c-3c31-ed6cd59f8043@SystematicSw.ab.ca>
Content-Language: it
Precedence: list
From: Marco Atzeri via Cygwin <cygwin@cygwin.com>
Reply-To: Marco Atzeri <marco.atzeri@gmail.com>
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Errors-To: cygwin-bounces@cygwin.com
Sender: "Cygwin" <cygwin-bounces@cygwin.com>
Content-Transfer-Encoding: 8bit

On 16.07.2020 06:25, Brian Inglis wrote:
> On 2020-07-15 14:13, Marco Atzeri via Cygwin wrote:
>> Problem: I want to search for
>>     libssh/libssh.h
>> Using https://cygwin.com/packages/
>> If I put the name and press Go the URL is changed in
>> https://cygwin.com/cgi-bin2/package-grep.cgi?grep=libssh%2Flibssh.h&arch=x86_64
>> and the output is
>>     Found 0 matches for libsshx2Flibssh.h
>>                               ^^^
>> Instead if I modify directly the URL in:
>> https://cygwin.com/cgi-bin2/package-grep.cgi?grep=libssh/libssh.h&arch=x86_64
>> Found 3 matches for libssh/libssh.h
>> ....
>> I guess that the current incapability is due to spurious urlencode in
>> cgi-bin2/package-grep.cgi
>> that is modifing the $param_grep
>> echo '<li><a href="package-cat.cgi?file='`urlencode
>> $partfile`'&amp;grep='`urlencode $param_grep`'">'$file'</a> - '$desc'</li>'
>> Could someone double check my guess ?
> 
> No change since your report on May 2nd, and my cross-post to overseers:
> 
> 	https://cygwin.com/pipermail/cygwin/2020-May/244684.html
> 
> 	https://sourceware.org/pipermail/overseers/2020q2/017115.html
> 
> where Frank suggested replacing badly urlencoded characters by ".":

this works as the dot is not changed

case $c in
             [a-zA-Z0-9.~_-]) printf "$c" ;;
             *) printf '%%%02X' "'$c"

> $ cygcheck -p libssh/libssh.h
> Found 0 matches for libsshx2flibssh.h
> $ cygcheck -p libssh.libssh.h
> Found 3 matches for libssh.libssh.h
> libssh-devel-0.7.3-1 - libssh-devel: SSH implementation library (installed
> binaries and support files)
> libssh-devel-0.7.5-1 - libssh-devel: SSH implementation library
> libssh-devel-0.8.7-1 - libssh-devel: SSH implementation library
> 
> The previous break appears to have been fixed by or due to Achim:
> 
> 	https://cygwin.com/pipermail/cygwin/2019-November/243112.html
> 
> Ping Achim?!
> 

the git logs says that only Frank and Jon have recently worked on

    cgi-bin2/package-grep.cgi

I would like to doble check any possible modification before proposing a
patch to change the web server...

Regards
Marco


--
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple