DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2D5513861893
Date: Mon, 6 Jul 2020 20:15:49 +0200
From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: Josh Thompson <josh_thompson@ncsu.edu>
Subject: Re: change in handling quotes in cygwin package from 3.1.4-1 to
 3.1.5-1
Message-ID: <20200706181549.GG514059@calimero.vinschen.de>
Mail-Followup-To: Josh Thompson <josh_thompson@ncsu.edu>, cygwin@cygwin.com,
 dev@vcl.apache.org
References: <3394273.JRUgpOGd2y@dvr> <2825592.AUrzYYFGSl@dvr>
 <20200706112247.GD514059@calimero.vinschen.de>
 <3197699.QRb4To3urE@dvr>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <3197699.QRb4To3urE@dvr>
Precedence: list
Reply-To: cygwin@cygwin.com
Cc: cygwin@cygwin.com, dev@vcl.apache.org
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cygwin-bounces@cygwin.com
Sender: "Cygwin" <cygwin-bounces@cygwin.com>

On Jul  6 10:14, Josh Thompson wrote:
> > > On Monday, June 22, 2020 4:11:35 PM EDT Ken Brown wrote:
> > > > On 6/15/2020 12:21 PM, Josh Thompson wrote:
> > > > [...]
> > > > > 3.1.4:
> > > > > $ cmd.exe /c "echo \""
> > > > > "
> > > > > 
> > > > > 3.1.5:
> > > > > $ cmd.exe /c "echo \""
> > > > > \"
> > > > [...]
> > > > After installing the rebuilt 3.1.4, however, the cmd.exe call above
> > > > exhibits the "3.1.5" behavior rather than the "3.1.4" behavior.  I
> > > > can't see anything in the patches that would explain this.  I thought
> > > > maybe it was a compiler optimization problem, but rebuilding without
> > > > optimization doesn't change anything.
> > > [...]
> > > It sounds like it will be difficult to change the quote behavior.  So,
> > > we'll work to get VCL updated to handle the new behavior.
> > 
> > I have a fix for that.  It's a long standing bug, a buffer overrun,
> > which seem to have had no effect pre-3.1.5 only because the older GCC
> > toolchain had a subtily different stack allocation strategy.
> > 
> > I uploaded developer snapshots to https://cygwin.com/snapshots/
> > for testing.  Please give this a try and report back.
> > 
> > If this fixes your problem, the bug is serious enough to qualify for
> > a Cygwin 3.1.6 RSN.
> 
> Thank you for this!  I can confirm that replacing cygwin1.dll with the 
> cygwin1-20200706.dll that you uploaded to the snapshot site fixes the quote 
> issue.
> 
> I upgraded an installation I had to 3.1.5-1 and tested that I was seeing the 
> problem by running
> 
> cmd.exe /c "echo \""
> \"
> 
> Next, I downloaded, uncompressed, and overwrote cygwin1.dll with 
> cygwin1-20200706.dll and tested again
> 
> cmd.exe /c "echo \""
> "
> 
> Great job working through that issue.

Thanks for testing and confirming.  Expect 3.1.6 in the next couple
of days.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
--
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple