Date: Fri, 13 Mar 2020 11:12:47 +0100
From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin@cygwin.com
Subject: Re: Setting termios VMIN > 0 and VTIME > 0 on non blocking file
Message-ID: <20200313101247.GD512788@calimero.vinschen.de>
Mail-Followup-To: cygwin@cygwin.com
References: <9e4c6428-59de-df07-9e33-44ba95d5497f@gmail.com>
 <20200312114041.GJ4042@calimero.vinschen.de>
 <365dd437-7553-eb4e-3253-aba3bab74895@gmail.com>
 <20200312144445.GP4042@calimero.vinschen.de>
 <20200312150833.GQ4042@calimero.vinschen.de>
 <9e56e005-660b-373e-d557-9c8bc97c45ba@gmail.com>
MIME-Version: 1.0
In-Reply-To: <9e56e005-660b-373e-d557-9c8bc97c45ba@gmail.com>
Precedence: list
Reply-To: cygwin@cygwin.com
Content-Type: multipart/mixed; boundary="===============8467874328838463228=="
Errors-To: cygwin-bounces@cygwin.com
Sender: "Cygwin" <cygwin-bounces@cygwin.com>


--===============8467874328838463228==
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="4jXrM3lyYWu4nBt5"
Content-Disposition: inline


--4jXrM3lyYWu4nBt5
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mar 12 18:04, =C3=85ke Rehnman via Cygwin wrote:
>=20
> On 2020-03-12 16:08, Corinna Vinschen wrote:
> > On Mar 12 15:44, Corinna Vinschen wrote:
> > > On Mar 12 15:20, =C3=85ke Rehnman via Cygwin wrote:
> > > > I think the problem is if the number of bytes requested are more th=
an what
> > > To clarify: number of bytes =3D=3D VMIN?
> no number of bytes requested from ReadFile(). As far as I know Win32 has =
no
> concept of VMIN.

Right, just this weird TimeoutMultiplier, but nevertheless I wasn't sure
what you meant.

> > > > is in the buffer it is going to overlap the read function (because =
of VTIME)
> > > > and immediately after that CancelIO is called. Contrary to what is =
mentioned
> > > > in the source code I think CancelIO is actually discarding data...
> > > So far we didn't have that experience.  CancelIO is usually safe
> > > in this regard.
> The data is MIA somehow...

Yes, but we're calling CancelIo in other circumstances in Cygwin and
there were no reports of missing data.  CancelIo is just supposed to
terminate the currently running overlapped IO, not to discard any
in-flight data.  If that's different for serial IO, there would be no
way to terminate serial overlapped IO gracefully.  Well, yeah, it's
Windows, but still...

> > > > -=C2=A0=C2=A0=C2=A0 if ((vmin_ > 0) && (vtime_ =3D=3D 0))
> > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (is_nonblocking())
> > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 {
> > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0 to.ReadIntervalTimeout =3D MAXDWORD;
> > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 }
> > > > +=C2=A0=C2=A0=C2=A0 else if ((vmin_ > 0) && (vtime_ =3D=3D 0))
> > > What if you switch to !O_NONBLOCK after calling tcsetattr?  The
> > > setting of ReadIntervalTimeout would be lost then.
> > >=20
> > > Either we have to repeat calling SetCommTimeouts every time
> > > we switch mode, or we have to do the above setting temporary
> > > every time we call ReadFile in non blocking mode.
> True.
> > What about this:
> >=20
> > diff --git a/winsup/cygwin/fhandler_serial.cc b/winsup/cygwin/fhandler_=
serial.cc
> > --- a/winsup/cygwin/fhandler_serial.cc
> > +++ b/winsup/cygwin/fhandler_serial.cc
> > @@ -68,6 +68,16 @@ fhandler_serial::raw_read (void *ptr, size_t& ulen)
> >   	goto err;
> >         else if (ev)
> >   	termios_printf ("error detected %x", ev);
> > +      else if (is_nonblocking ())
> > +	{
> > +	  if (!st.cbInQue)
> > +	    {
> > +	      tot =3D -1;
> > +	      set_errno (EAGAIN);
> > +	      goto out;
> > +	    }
> > +	  inq =3D st.cbInQue;
> > +	}
> >         else if (st.cbInQue && !vtime_)
> >   	inq =3D st.cbInQue;
> >         else if (!is_nonblocking () && !overlapped_armed)
>=20
> Looks promising. I will try it.
>=20
> BTW there is a gremlin in the "else if (ev)" line....

A gremlin?  Would you mind to explain?  Btw., if you find a bug
in the code, we do take patches :) https://cygwin.com/contrib.html


Thanks,
Corinna

--=20
Corinna Vinschen
Cygwin Maintainer

--4jXrM3lyYWu4nBt5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEoVYPmneWZnwT6kwF9TYGna5ET6AFAl5rXJ8ACgkQ9TYGna5E
T6AefRAAibV5MzaFKXnQ62SDtMndBB1uWiksMykgKtaDOyYYoGB5dyHtp/U3sZoi
Nolmjcq0S1IcIgGF0m9aS8oNbo7cGtSRanOfNkOjibEvNcVg9FlU0XzHUB3uCpYF
uZeCGn1nrLodv0uhrqYapAX9vukqRvbmjM5j4ItBAe6+cIfMyszhIcg79dxduRTM
OegKc+TR+3Vz5IpMyLcE5yfUi3USZr0UUIkEfVoijwadLpYe+qNdjAikuxPG+K+8
EMVMUamAg4B6U1Ky+6Jt9pj+tRuQVU4mt1uhu3dCirynKvBA5IbMoT6Jxye3PLXC
NCfFvgb68nTGGq6qEWZx+xDvNO0WFWMgD+WKMU3IJSQIWb9dONHr9ZoV1jpA1Oep
YhIe9+E9ZIJmsP2q4ACNANvDuVwgaONTfDvfk+f68fdA3Ty1Hv5pnJbiX45ILtYr
fdTXNn5HK7Dt7zFNKysvuptHQ8skSA75VWULWyPuJAtvGW1OY2ybFgeUF+/Nyuow
FqY4DAgFqp5v42M2gTQA0XhM2Bio+9hxowzPmb7xo7PiPQLzOverp2z85jeHOJJg
RZLvwSyXGIbb4FcSyF0nTWC6T5bgyJJP6jYR57l8Q69FfQghb9x2ZaHhUfcIS5wB
PxmMbzBqyuFvpA2EY7LDI/maN6W4F/S3BbqTqZ+G50qPLgwKxyQ=
=p84u
-----END PGP SIGNATURE-----

--4jXrM3lyYWu4nBt5--

--===============8467874328838463228==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

--===============8467874328838463228==--