DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:from:to:cc:subject:date:message-id:in-reply-to
	:references:mime-version:content-type:content-transfer-encoding;
	 q=dns; s=default; b=eLod13zHz3BcFArS+nErS/D6Ut1B5MhIX+T0HL9HtcI
	oVgkP3vyUeW3lvDTHBtN/OoheMFTj/z4OGDNAS9XJ+QW0xhyCu3mP8cKGKjIPW68
	X+okeVAbAGwtbVMjUNPmiI+cyUT2M7Y1ibEyztwi4cnvIwBh4Rr9VBixPaqShmF0
	=
Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm
Sender: cygwin-owner@cygwin.com
Mail-Followup-To: cygwin@cygwin.com
From: Bruno Haible <bruno@clisp.org>
To: cygwin@cygwin.com, Corinna Vinschen <corinna-cygwin@cygwin.com>
Cc: Corinna Vinschen <corinna@vinschen.de>
Subject: Re: ilogbl(0.0L) value is wrong
Date: Tue, 17 Dec 2019 12:04:39 +0100
Message-ID: <1754103.YWv04siWQO@omega>
User-Agent: KMail/5.1.3 (Linux/4.4.0-166-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <20191216100122.GM10310@calimero.vinschen.de>
References: <2040599.24iSPLvMXZ@omega> <20191216100122.GM10310@calimero.vinschen.de>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="nextPart12332903.bQUd7PJCA0"
Content-Transfer-Encoding: 7Bit

--nextPart12332903.bQUd7PJCA0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"

Hi Corinna,

> I pushed this patch:
> 
>   https://sourceware.org/git/?p=newlib-cygwin.git;a=commitdiff;h=29ba52da9553
> 
> Please test the latest developer snapshot from https://cygwin.com/snapshots/

I can't test it easily.

But the code looks good; only the comments could be improved; patch attached.

Bruno

--nextPart12332903.bQUd7PJCA0
Content-Disposition: attachment; filename="ilogbl-comment.diff"
Content-Transfer-Encoding: 7Bit
Content-Type: text/x-patch; charset="UTF-8"; name="ilogbl-comment.diff"

diff --git a/winsup/cygwin/math/ilogbl.S b/winsup/cygwin/math/ilogbl.S
index a4fe503..e4a2660 100644
--- a/winsup/cygwin/math/ilogbl.S
+++ b/winsup/cygwin/math/ilogbl.S
@@ -17,14 +17,14 @@
 __MINGW_USYMBOL(ilogbl):
 #ifdef __x86_64__
 	fldt	(%rcx)
-	fxam			/* Is NaN or +-Inf?  */
+	fxam			/* Is NaN or +-Inf or +-0?  */
 	fstsw   %ax
 	movb    $0x45, %dh
 	andb    %ah, %dh
 	cmpb    $0x05, %dh
 	je      1f		/* Is +-Inf, jump.  */
 	cmpb	$0x40, %dh
-	je	2f		/* Is +-Inf, jump.  */
+	je	2f		/* Is +-0, jump.  */
 
 	fxtract
 	pushq	%rax
@@ -47,14 +47,14 @@ __MINGW_USYMBOL(ilogbl):
 /* I added the following ugly construct because ilogb(+-Inf) is
    required to return INT_MAX in ISO C99.
    -- jakub@redhat.com.  */
-	fxam			/* Is NaN or +-Inf?  */
+	fxam			/* Is NaN or +-Inf or +-0?  */
 	fstsw   %ax
 	movb    $0x45, %dh
 	andb    %ah, %dh
 	cmpb    $0x05, %dh
 	je      1f		/* Is +-Inf, jump.  */
 	cmpb	$0x40, %dh
-	je	2f		/* Is +-Inf, jump.  */
+	je	2f		/* Is +-0, jump.  */
 
 	fxtract
 	pushl	%eax


--nextPart12332903.bQUd7PJCA0
Content-Type: text/plain; charset=us-ascii


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
--nextPart12332903.bQUd7PJCA0--