DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; q=dns; s=
	default; b=JknNpBmX9ULwqAs/Z6xiaGSOSQDsbgB8XDLDlk8/sO5s6G8VCzmHA
	8BcAZTPnTNj0bxalBpVRBOzPSyAmC0Kj+g5GVubG487Frce1idcAYbUXaRxzKOMW
	iLI+MgvsAuOZcSU9YIQz1f6E4QtqLGq41KFp+EivKR2uHGvpx5WksQ=
Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm
Sender: cygwin-owner@cygwin.com
Mail-Followup-To: cygwin@cygwin.com
Date: Sun, 17 Feb 2019 10:08:20 +0100
From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin@cygwin.com
Subject: Re: fixup_mmaps_after_fork failure with cygwin-3.0.0
Message-ID: <20190217090820.GI4256@calimero.vinschen.de>
Reply-To: cygwin@cygwin.com
Mail-Followup-To: cygwin@cygwin.com
References: <1d506605-a0af-12c2-6faf-ac74ab842182@cornell.edu>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;	protocol="application/pgp-signature"; boundary="lQSB8Tqijvu1+4Ba"
Content-Disposition: inline
In-Reply-To: <1d506605-a0af-12c2-6faf-ac74ab842182@cornell.edu>
User-Agent: Mutt/1.10.1 (2018-07-13)

--lQSB8Tqijvu1+4Ba
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Feb 17 00:11, Ken Brown wrote:
> I'm getting a lot of errors like this when building emacs from its git re=
po:
>=20
> EMACSLOADPATH=3D '../src/emacs.exe' -batch --no-site-file --no-site-lisp =
--eval=20
> '(setq load-prefer-newer t)'  -f batch-byte-compile ../../master/lisp/fin=
der.el
>        1 [main] emacs 26848 fixup_mmaps_after_fork: VirtualProtectEx fail=
ed for=20
> MAP_PRIVATE address 0x6FFFFCD0000, Win32 error 5
>      190 [main] emacs 26848 C:\Users\kbrown\src\emacs\x86_64\src\emacs.ex=
e: ***=20
> fatal error in forked process - recreate_mmaps_after_fork_failed
>      619 [main] emacs 26848 cygwin_exception::open_stackdumpfile: Dumping=
 stack=20
> trace to emacs.exe.stackdump
>        1 [main] emacs 27052 fork: child -1 - forked process 26848 died=20
> unexpectedly, retry 0, exit code 0x100, errno 11

Weird.  I built at least gawk and openssh with 3.0 already and I
didn't notice this problem.

> A bisection points to the following as the first bad commit:
>=20
> commit 69cc7a068656b5c6ef07ca079a213f801e02e650
> Author: Corinna Vinschen <corinna@vinschen.de>
> Date:   Sun Jan 27 13:15:15 2019 +0100
>=20
>      Cygwin: fork: restrict parent handle perms and drop handle after use
>=20
>=20
> I'll try to do some debugging and/or provide further information tomorrow=
, but I=20
> thought I'd start with this preliminary report.

That would be nice.  It's not clear to me which permission is missing.
The first part of the patch has been reverted in 3.0.0, so=20
child_info_spawn::get_parent_handle opens the parent with
PROCESS_VM_READ again.  The second patch has been reworked as well,m
the current perms are

PROCESS_QUERY_LIMITED_INFORMATION | PROCESS_VM_READ | SYNCHRONIZE

If I may place a bet, please try to replace
PROCESS_QUERY_LIMITED_INFORMATION with PROCESS_QUERY_INFORMATION

What OS is that?  W7?


Corinna

--=20
Corinna Vinschen
Cygwin Maintainer

--lQSB8Tqijvu1+4Ba
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEoVYPmneWZnwT6kwF9TYGna5ET6AFAlxpJIQACgkQ9TYGna5E
T6BfoA/9E6iTQJkkMHGOJq6jFAqdr1it7Ci7dn9tYBduiLbDWaueJ02sZkRluFu1
E7gXO1PsG78U0jLvsuwUByLtFJbzev7149MdSXK0VhrIkNLuD3NtjIzVwWa/189e
INI0AqLATxonrvxe7CYogHXCv3MZWZK/0aBMT+Hhb5D5qsfR25o+7K1kKcrq7eNj
Co0ASdxO59s789nF3tOeEETx7d3bVbhpVVXoDdjmMX0t5y5WshMZp4cAxIAfRc6X
VQltIyg1y4Rwx6rHb63lH28TGJ51qZV0oQ53e1/eWcsDO4g1CIljj3BDzR6tOJS9
53zVH1TcV/UCb1lq7aeCtUJQEQ8EbeIv3WRjxc/dBXh/oJF7kLPB5B/jcC2JYjni
QQbXxo5CrCNRd/eCYazebw63AYqLd691Bly0+1qDJMnMeZyZcbmWCFJMt4wKr3fH
IRxof+/ZUrLyAfdqd6lz20dbzVRiqgthpvByotqCOrdwVxlY+WpBlXgCmyJkFgu6
lvwhz861bK0a4aRwQJmh5J54EKWPDTU62BC/GtsYCvgRV0bKzeSmZAUcELdE7dqN
BXmhuL1WybWfD+iWR98J3jHACocmMeeSRpMsJ1CdHZ/ROe7BxYB4GJZZx07lhfRY
tZhICPe19+/cca7j/u3ac19v+GWfQ9vefyWDTSbIb55K9Kqw9/c=
=ICys
-----END PGP SIGNATURE-----

--lQSB8Tqijvu1+4Ba--