DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:cc:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; q=dns; s=
	default; b=cWUvW2bNYg4lkSaQNybD8U1guukW6S5XLayyYk5Au7P9pw017bixt
	MwJUesCPEAzpoTEt+UiQCRoGGRNx/1QYYAJDVgxfo+jSB4vL3R+brLr8x/GfnOY7
	rKOakf8+rlG1xwKqIjqZ3mWfbNT5thc740n6yVwelHI8swOOWoQ3BY=
Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm
Sender: cygwin-owner@cygwin.com
Mail-Followup-To: cygwin@cygwin.com
Date: Fri, 8 Feb 2019 15:48:27 +0100
From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: Michael Haubenwallner <michael.haubenwallner@ssi-schaefer.com>
Cc: cygwin@cygwin.com
Subject: Re: [ANNOUNCEMENT] TEST: Cygwin 3.0.0-0.7
Message-ID: <20190208144827.GR13951@calimero.vinschen.de>
Reply-To: cygwin@cygwin.com
Mail-Followup-To: Michael Haubenwallner <michael.haubenwallner@ssi-schaefer.com>,	cygwin@cygwin.com
References: <20190207182735.GG13951@calimero.vinschen.de> <8a2f041f-f8f7-6e17-5d97-5a168440009b@ssi-schaefer.com> <20190208113158.GH13951@calimero.vinschen.de> <17e339bb-2115-bf22-7291-04215aab3150@ssi-schaefer.com> <20190208122126.GM13951@calimero.vinschen.de> <20190208122338.GN13951@calimero.vinschen.de> <b07e6ba2-0ce0-4662-7a02-bda6ce3b0108@ssi-schaefer.com> <20190208130635.GO13951@calimero.vinschen.de> <20190208132807.GP13951@calimero.vinschen.de> <6b182191-b235-fcbb-5b25-66243950043c@ssi-schaefer.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;	protocol="application/pgp-signature"; boundary="HLsZ5Z1opAQvdr2J"
Content-Disposition: inline
In-Reply-To: <6b182191-b235-fcbb-5b25-66243950043c@ssi-schaefer.com>
User-Agent: Mutt/1.10.1 (2018-07-13)

--HLsZ5Z1opAQvdr2J
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Feb  8 15:43, Michael Haubenwallner wrote:
>=20
>=20
> On 2/8/19 2:28 PM, Corinna Vinschen wrote:
> > On Feb  8 14:06, Corinna Vinschen wrote:
> >> On Feb  8 13:52, Michael Haubenwallner wrote:
> >>> On 2/8/19 1:23 PM, Corinna Vinschen wrote:
> >>>> On Feb  8 13:21, Corinna Vinschen wrote:
> >>>>> On Feb  8 12:51, Michael Haubenwallner wrote:
> >>>>>>
> >>>>>> For now it seems like there's an inconsistency with PIDs:
> >>>>>> A first process PID 100, receives PID 101 from spawn(),
> >>>>>> but in the new process getpid() returns 102:
> >>>>>>
> >>>>>> $ ./dospawn /bin/bash -c 'echo $$'
> >>>>>> 12625
> >>>>>> waitpid: pid 12624 status 0x0
> >>>>>
> >>>>> Oh, hmm.  If you call spawnve, rather than execve, a new child pid
> >>>>> is generated in spawnve, rather than just keeping the callers pid.
> >>>>>
> >>>>> However, apparently the child invents its own pid in pinfo::thisproc
> >>>>> after being spawned.  But actually this should only occur for forked
> >>>>> processes aore processes started from non-Cygwin parents.
> >>>>
> >>>> Does that help, by any chance:
> >>>> [nope]
> >>>
> >>> How should the child be informed at all about the new cygpid value ge=
nerated in
> >>> parent's child_info_spawn::worker() ?
> >>
> >> I just realized this myself.  The old method creating Cygwin pids just
> >> fetched the pid from GetCurrentProcessId(), which was right for spawned
> >> (but not execed) processes.  For the new pid we might have to give this
> >> to the child via child_info_spawn.
> >=20
> > This works for me, can you test this, too, please?
>=20
> Looks good to me as well, I'm going to start my hours running use case no=
w.

Sounds good, thanks.  I'll push this change now.  We can always
rework it if it's insufficient.

> > I pushed your forkable branch to master, btw.  Would you mind to do the
> > honors in the ;rease notes at cygwin/release/3.0 and doc/new-features.x=
ml?
>=20
> Ok, just preparing the tests first. Thanks a lot!

No worries, as long as I know you're here to answer questions ;)


Corinna

--=20
Corinna Vinschen
Cygwin Maintainer

--HLsZ5Z1opAQvdr2J
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEoVYPmneWZnwT6kwF9TYGna5ET6AFAlxdlrsACgkQ9TYGna5E
T6Bk1RAApL0PuUExqU+IaQlKe6zZAi8MgNc4Iab2W2JxFMst/UBlILuvL6+n1iDC
TSAbjYSp8VhkT9n2AdrtLiRTvRtKvGlBTm1OCctGoBC5geO4ogMoia1309ShYQmA
b25jHByK32H1ie3NbG1+0zzbIxojrrESz82L8xogI//jHRog9msn17THdqdoef5o
U4sb023HZApcSidoBcar4EGJH9mzgbdjGbFFHqOXl4N1dRNQIHS4jROnUsTGNrej
TNZnzSACRfRNbiDZOpcTNBGXEPkxVrH/GXNk2z5v158pBufBaG/OJSuxCFEhjwJO
JzAxuvwYWSMqQEaQIs09XFOyJJse751CCl+pOBdAaHe1LRhObPzCiRGat8GO4I0C
toEBRBPujsuK4mcsUgdsq5PDqOhMsDHwclcwgs+iZ1hSiiwFfDUy7QLIufKVqAHK
O6bRX8OJzbudZ/WU9M2ECB39ofmtFC13s7GkqzBFit35G0NvUYIPeH2g/Q8e0s65
fprrMwlf64mv2/WR7ozp8RKIEYSpB6ySWeMCC4aXg+2Sea2cTlxntV3oQ60k4ll+
AbfEESmL355GFmVMWCiRmhJh8NzTwiWnB5KV09/C6U7/GDwWNjXQiSVLBzAGpyG5
V4WUOOfNiFzHJ/UeL6s5/KbCYxWr6/FaeDNMDtVJqOwGf++RHnQ=
=Cwkn
-----END PGP SIGNATURE-----

--HLsZ5Z1opAQvdr2J--