DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:subject:to:references:from:message-id:date
	:mime-version:in-reply-to:content-type
	:content-transfer-encoding; q=dns; s=default; b=f92HpYQuBn4la3u2
	HLNWMgOxWL4VBl4tuQ3wrtbLRS25z+iumlTO1HSughIDT50N0vQ+nCbcUdBl8PFk
	iY7c9OxmbA8JZREla9I18chOn/RUKZqohnl3S/m6JzdpKGPSJ5rAtMI0/uJc742Y
	Au/U8loN23MNNka22a7kLamlcD4=
Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm
Sender: cygwin-owner@cygwin.com
Mail-Followup-To: cygwin@cygwin.com
Subject: Re: iswcntrl() regression
To: cygwin@cygwin.com
References: <24530320.43gEWRNkUz@omega> <cd4691c0-da99-46b5-6001-594499a8d2fa@towo.net> <20181219133711.GJ28727@calimero.vinschen.de> <6550638.IhVCuUnqCC@omega> <20190106202109.GD4430@calimero.vinschen.de> <8758e963-7f32-a3f4-4d66-ce0d0c5f831e@towo.net> <18c44153-0e69-80f9-81c7-544009f83b8c@towo.net> <20190111091634.GS593@calimero.vinschen.de>
From: Thomas Wolff <towo@towo.net>
Message-ID: <625240da-c6b1-05e1-35b2-f39021287fcb@towo.net>
Date: Sat, 12 Jan 2019 12:39:38 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0
MIME-Version: 1.0
In-Reply-To: <20190111091634.GS593@calimero.vinschen.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit

Am 11.01.2019 um 10:16 schrieb Corinna Vinschen:
> On Jan 11 02:07, Thomas Wolff wrote:
>> Am 06.01.2019 um 23:39 schrieb Thomas Wolff:
>>> Am 06.01.2019 um 21:21 schrieb Corinna Vinschen:
>>>> On Dec 19 21:57, Bruno Haible wrote:
>>>>> Hello Thomas,
>>>>>
>>>>> Oops 1: I forgot to add the reference to POSIX:
>>>>> http://pubs.opengroup.org/onlinepubs/9699919799/functions/iswcntrl.html
>>>>>
>>>>> Oops 2:
>>>>> The relevant expression is iswcntrl (WEOF), not iswcntrl (EOF).
>>>>> [...]
>>>> Thomas, any input?  Are you going to provide patches?
>>> Well, yes, now I'm assuming that this is the only WEOF special case and
>>> I'll look after it this week.
>>> Thomas
>> The fix should be as attached.
>> However, I don't seem to be able to produce a git format patch; when I `git
>> format-patch -1` (after `git pull` and modifying only the affected file) it
>> produces a patch file
>>
>> Subject: [PATCH] Cygwin: try_to_bin: don't check recycler filename all the
>> time
>> ...
>> Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
>> ---
>>   winsup/cygwin/syscalls.cc | 71 +++++++++++++++++++++------------------
>> ...
>>
>> which is weird.
> No, it's not.  Only commited patches are printed by `git format-patch',
> so, after `git pull' you have to *commit* your patches, write a nice
> description (with a blank line after the first line to separate the
> commit message into synopsis and body).  *Then* call `git format-patch -1'.
Blush; forgot about the workflow...
> Apart from that, please send your patch to the newlib mailing list.
Done.
Also sent a Unicode 11.0 update patch.
Thomas

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple