DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:mime-version:references:in-reply-to:from:date
	:message-id:subject:to:content-type; q=dns; s=default; b=P97EkV8
	bhZNJXwLsuLuutyRQE0j/J7YIfRQ2TOZyLz26VH+d+AFqTzUDe/BGEMNG64IsDs2
	6oPLC3tGp+PbJEAFhBiKZTTXSTpwH3lBj9kO4fSYt9zXccpAsjjVFBVsoBXpK85p
	HZhAiyAxy2VEKLCHNguFRxiAUMtuEnReK45Q=
Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm
Sender: cygwin-owner@cygwin.com
Mail-Followup-To: cygwin@cygwin.com
MIME-Version: 1.0
References: <CAPF-yObTngOGu_+TSfSQo4bpi_tJ3572r_26cfidLZ5QpcPGYQ@mail.gmail.com> <f00936b7-cc2a-1a2c-7862-c79e10bed95d@gmail.com> <02c12d6e-cc18-89af-db83-1813cc8f0c97@redhat.com>
In-Reply-To: <02c12d6e-cc18-89af-db83-1813cc8f0c97@redhat.com>
From: Dan Kegel <dank@kegel.com>
Date: Tue, 9 Oct 2018 09:21:51 -0700
Message-ID: <CAPF-yObUNPRE_xrnroc_rZHqPHGUGmzMKZXnT5ZrpLm2YCzW-g@mail.gmail.com>
Subject: Re: Fun with cp -R error when both foo and foo.exe exist
To: cygwin@cygwin.com
Content-Type: text/plain; charset="UTF-8"

On Tue, Oct 9, 2018 at 5:03 AM Eric Blake <eblake@redhat.com> wrote:
> whether someone patches the cygwin dll or cp, it seems like some rather
> hairy code for what is normally a rare corner case, so it probably won't
> happen unless someone actually contributes a patch.

Right.  Here's a completely untested guess patch:

--- a/winsup/cygwin/syscalls.cc
+++ b/winsup/cygwin/syscalls.cc
@@ -1363,7 +1363,15 @@ open (const char *unix_path, int flags, ...)
          opt |= PC_CTTY;
        }

-      if (!(fh = build_fh_name (unix_path, opt, stat_suffixes)))
+      suffix_info *suffices = stat_suffixes;
+      if ((opt & (O_WRONLY|O_BINARY)) == (O_WRONLY|O_BINARY))
+        {
+         /* Hack so 'cp foo bar' doesn't abort with
+             'cp: cannot create regular file bar: File exists'
+            if bar.exe already exists  */
+       suffices = NULL;
+       }
+      if (!(fh = build_fh_name (unix_path, opt, suffices)))
        __leave;                /* errno already set */
       if ((flags & O_NOFOLLOW) && fh->issymlink ())
        {

Feel free to throw rotten fruit :-)

- Dan

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple