DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:mime-version:content-type
	:content-transfer-encoding:date:from:to:subject:in-reply-to
	:references:message-id; q=dns; s=default; b=EgWwocCk0bzVPM2GuwUg
	YuxnwxFqLgksAeqQXqQALGfbsJvJ9IHIP3D+I48CfksRQqOPuZ+I3LF18TfC1JR3
	C5g6od+MgY/ZNM4Yn3w8VUPtaLzyKKFmBZ5Fy7znKbjXXmWWr+yJQiufox1ZxvRJ
	87o5y6X4pNystzvkBCzZRD0=
Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm
Sender: cygwin-owner@cygwin.com
Mail-Followup-To: cygwin@cygwin.com
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII; format=flowed
Content-Transfer-Encoding: 7bit
Date: Thu, 02 Aug 2018 17:14:52 +0200
From: Houder <houder@xs4all.nl>
To: cygwin@cygwin.com
Subject: Re: x86_64: floating-point environment (i.e. fenv.h). BUG.
In-Reply-To: <4438ec88ad4e6965281be138d93ba45d@xs4all.nl>
References: <3a882a7d38c52dc5a14d176f30f8340e@xs4all.nl> <20180801110009.GA30124@calimero.vinschen.de> <4438ec88ad4e6965281be138d93ba45d@xs4all.nl>
Message-ID: <76343c2b9f4a4bbb8bece5150098733a@xs4all.nl>
User-Agent: XS4ALL Webmail

On 2018-08-01 13:49, Houder wrote:
> On 2018-08-01 13:00, Corinna Vinschen wrote:
>> On Aug  1 12:22, Houder wrote:
>>> Hi Corinna,
>>> 
>>> Short version of my report (as there is more to say about the 
>>> implementation
>>> of
>>> "fenv") in Cygwin; this time I restrict myself to a bug in fegetenv() 
>>> ).
>>> 
>>> (Note to myself: attach STC)
>>> 
>>> I am reporting a bug in fegetenv() in winsup/cygwin/fenv.cc. There is 
>>> no
>>> hurry
>>> in repairing this bug, as "fenv" is hardly ever (never?) used by 
>>> anyone.
>>> 
>>> fegetenv() should be modified as follows:
>>> 
>>> from:
>>>   __asm__ volatile ("fnstenv %0" : "=m" (envp->_fpu) : );
>>>   if (use_sse)
>>>     __asm__ volatile ("stmxcsr %0" : "=m" (envp->_sse_mxcsr) : );
>>>   return 0
>>> 
>>> to:
>>> // Henri: copying glibc ...
>>>   __asm__ volatile ("fnstenv %0\n"
>>>                     "fldenv %0" : "=m" (envp->_fpu) : );
>>>   if (use_sse)
>>>     __asm__ volatile ("stmxcsr %0" : "=m" (envp->_sse_mxcsr) : );
>>>   return 0;
>> 
>> Since you know how to fix things, please just send patches to
>> the cygwin-patches ML.
> 
> Ah ... Agreed. However, as I am not set up for building (anymore), this
> will take some time ... (not even git is installed).
> 
> (yes, I did verify the above modification (and more), however I did 
> that
>  "locally" (basically, I included winsup/cygwin/fenv.cc in my  STC) ).

Corinna,

As requested by you, I made an attempt. See cygwin-patches.

Regards,

Henri

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple