DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:mime-version:in-reply-to:references:from:date
	:message-id:subject:to:content-type; q=dns; s=default; b=yXN1LrG
	4SZ3OTcsUpBGCSKgGGTu+baxxBfdBocTtS6W4Z5hmJ+7UbQnODj10j+fzkg5syNO
	67Wa5uGq+VdiT364Y2rwpKeef2thmtjhKNpl/n1zSKxyip7dT/utykPz1Mzs5ZXl
	3+190inhvr4uf8IBbKe8RUlwC4LehYz2E9rA=
Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm
Sender: cygwin-owner@cygwin.com
Mail-Followup-To: cygwin@cygwin.com
MIME-Version: 1.0
In-Reply-To: <874lmu6lgx.fsf@Rainer.invalid>
References: <CAOTD34ZtrCO4tAKBx0oUd4w9ic5h6djZ3vBJMwGEma6VNiytfg@mail.gmail.com> <874lmu6lgx.fsf@Rainer.invalid>
From: Erik Bray <erik.m.bray@gmail.com>
Date: Tue, 13 Feb 2018 19:26:31 +0100
Message-ID: <CAOTD34b2Mom2uRY86BF+sATtUs2bwy2x2x3-s7xVs+0SNZ+iJQ@mail.gmail.com>
Subject: Re: OpenBLAS patch for Cygwin
To: cygwin@cygwin.com
Content-Type: text/plain; charset="UTF-8"

On Tue, Feb 6, 2018 at 7:07 PM, Achim Gratz wrote:
> Erik Bray writes:
>> Assuming this looks good (feedback welcome) it might be nice to have
>> this patch included in the next release of the official OpenBLAS
>> package for Cygwin since its incompatibility with fork() has caused
>> problems in the past [1].
>
> It would be vastly preferrable if OPenBLAS ditched the (unfortunately
> quite common) notion that "Cygwin is some sort of Windows" for "Cygwin
> is some sort of Linux".  I've patched out quite some bit of conditionals
> like that in some other packages and it was almost always for the
> better.  The worst ones are those that go into the Windows conditional
> branch and then on to "oh wait, but for Cygwin we need something else".

Yup--OpenBLAS treats Cygwin as "some sort of Windows" and you can see
in my pull requests that there are some conditions like "if WINDOWS &&
!CYGWIN".

I will probably try another patch to remove that notion in general.

I've had a little other experience with patching OpenBLAS for Cygwin
and it's one of those cases where upstream is, fortunately, receptive
to supporting it as a platform.  Their existing Cygwin support has
just been a bit janky (a previous patch I submitted installed the DLL
as cygopenblas.dll instead of libopenblas.dll, for example).

Best,
E

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple