DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:reply-to:message-id:to:subject
	:in-reply-to:references:mime-version:content-type
	:content-transfer-encoding; q=dns; s=default; b=BLVrVRB1uOJMu4NH
	eo1ATF5OH8rgd4ydi9KWWpPrPbxz9bBBoisXIWr25WL24mZWZoHhQWMy3aP2tqN8
	Jh9mDCFIxcnirjQzMyb34Rl6D65xS4ZVx+HdY5kUrgRvxCDFVZlvMih7mKKdyQv2
	td05621WZg0THjgbl2VyDXQv/pE=
Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm
Sender: cygwin-owner@cygwin.com
Mail-Followup-To: cygwin@cygwin.com
Date: Thu, 14 Dec 2017 22:46:16 +0300
From: Andrey Repin <anrdaemon@yandex.ru>
Reply-To: cygwin@cygwin.com
Message-ID: <116333312.20171214224616@yandex.ru>
To: Ken Brown <kbrown@cornell.edu>, cygwin@cygwin.com
Subject: Re: setup's response to a "corrupt local copy"
In-Reply-To: <b06765ec-3d9c-d52b-50c5-7ed22bbb8619@cornell.edu>
References: <b06765ec-3d9c-d52b-50c5-7ed22bbb8619@cornell.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

Greetings, Ken Brown!

> This is a followup to the discussion started here:

>    https://cygwin.com/ml/cygwin/2017-12/msg00088.html

> When setup is preparing to download files and it finds a corrupt copy in 
> the local cache, it issues a fatal error message telling the user to 
> remove the corrupt file and retry.  Steven said that setup should 
> silently delete the corrupt file, while I argued in favor of the current 
> behavior, on the grounds that setup shouldn't be deleting user files if 
> it doesn't know where they came from.

The point being, if this is a "Download" Setup mode, the files are NOT "User"
files, but a local setup cache. And all files therein SHOULD be valid package
archives.
There's of course situations, when setup.ini on server become corrupted or
otherwise out of sync. But being rare, they should not interfere too much.

> There is a middle ground: setup could query the user.  Additionally, as 
> suggested by cyg Simple, there could be an option that directs setup to 
> silently remove corrupt files.

Make it mode dependent.
If it's a "download[ and install]" mode, cleanup and redownload.
If redownloaded file still does not match the setup.ini hash or if it's an
"install from local cache" mode, leave file alone for investigation and notify
the user.


-- 
With best regards,
Andrey Repin
Thursday, December 14, 2017 22:38:11

Sorry for my terrible english...


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple