DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:mime-version:in-reply-to:references:from:date
	:message-id:subject:to:cc:content-type; q=dns; s=default; b=M5xV
	DtTKR9MJoB9asvhgr/E+XScA8UqnDh5nRqWsKROLUs787BVsplWImhrDV+Vci2MZ
	dApuvwlcYobKWDc/O7d/Kay88iHgQp3DQGg40G6LOf5M+kb2n7MqxnIJhDsUouLB
	dtIiq2wFwB12JCdqjt4wuYkeK+W9NcZQ26JyM3Q=
Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm
Sender: cygwin-owner@cygwin.com
Mail-Followup-To: cygwin@cygwin.com
MIME-Version: 1.0
In-Reply-To: <8690f394-94f0-58ad-8a6b-8067edabc9d5@dronecode.org.uk>
References: <CAL_02JBn=m9z9d6cjJ==-wc1_k6iG=0rmRR4VqiOuB0vfAkovA@mail.gmail.com> <3e13ae03-786f-6157-00a3-53e909495751@dronecode.org.uk> <CAL_02JC8t9TM6bRyrovCVJRv+pogdn+fNH7kv8ha016XZw0irA@mail.gmail.com> <a7c24330-21d1-42aa-bc3b-db9620ac77d8@dronecode.org.uk> <CAL_02JCCmg4S03+Z1W_ADX0rR4nqxXcM0gjqhR07g56HNhQwkg@mail.gmail.com> <8690f394-94f0-58ad-8a6b-8067edabc9d5@dronecode.org.uk>
From: Ivan Gagis <igagis@gmail.com>
Date: Fri, 1 Dec 2017 00:16:43 +0200
Message-ID: <CAL_02JCSUXQ_gLbdKSxNaNXaDkWMKmgY_ntG-vjpchM2GpWT-w@mail.gmail.com>
Subject: Re: mksetupini fails validating packages because curr is test
To: Jon Turney <jon.turney@dronecode.org.uk>
Cc: The Cygwin Mailing List <cygwin@cygwin.com>
Content-Type: text/plain; charset="UTF-8"

Hi Jon,

Thanks for prompt actions!

I think no need to package it separately for testing, just release it
to cygwin repo.

Yes, I understand that there always is a human factor, this is why I
do all my building, version bumping up and deployment automatically by
scripts, so this check seems unnecessary in my case and good that it
can be turned off now.

Br,
Ivan

2017-11-30 14:41 GMT+02:00 Jon Turney <jon.turney@dronecode.org.uk>:
> On 30/11/2017 09:28, Ivan Gagis wrote:
>>
>> I use git repository on github to store the files. And to update it I
>> clone the repo, run mksetupini and then commit and push.
>> So, I'm not sure what actually is going on with mtime of the files
>> there. Perhaps git messes up the mtime of cloned files.
>
>
> Yes, a git checkout will have the mtime of the checkout.
>
> I've pushed an update to the calm repo with these changes:
>
> - mksetupini and calm now exit with non-zero exit status on an error
> - Fixes a bug where equal mtime was considered newer
> - Adds 'mksetupini --disable-check=curr-most-recent' option to turn off this
> check
>
> Do I need to package this for you to test it?
>
>> But why is this check of mtime needed at all? Isn't version number
>> enough for tracking earlier-later files?
>
>
> Maybe this doesn't make much sense in the context of mksetupini, but this is
> a useful check for calm to make.
>
> People make mistakes.
>
> People also forget the subtleties of how version numbers sort and upload
> versions which aren't greater than the current version, when they think they
> are...

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple