DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:subject:to:references:from:message-id:date
	:mime-version:in-reply-to:content-type; q=dns; s=default; b=fAdl
	qfc8asMTm52wESCfVAf/XrspDXmqs7faebqis0F8eXcDa37nlOMrhtEUOUanc0tf
	ddM77bRlvji+d0+TKl7GOENk7tOcmSw9tYc2l7UztwD4hgf5lslmF+W1o3yobgzb
	OX7MabbASo4CMb2CU6i2JhW0reAKlhmzQLPJtqI=
Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm
Sender: cygwin-owner@cygwin.com
Mail-Followup-To: cygwin@cygwin.com
DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 056D57D4F0
Subject: Re: bug in lrint [was: FW: Printing long int in C program under cygwin64]
To: cygwin@cygwin.com
References: <d252aaae-b298-6fc8-7e5b-8d8be9f27f21@redhat.com> <592618e3.08179d0a.27b5e.4630@mx.google.com>
From: Eric Blake <eblake@redhat.com>
Openpgp: url=http://people.redhat.com/eblake/eblake.gpg
Message-ID: <f38a6091-a097-baec-5f9b-927070cc4d5f@redhat.com>
Date: Thu, 25 May 2017 13:17:30 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0
MIME-Version: 1.0
In-Reply-To: <592618e3.08179d0a.27b5e.4630@mx.google.com>
Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bBA530V33nCN3VNlsEKFv4dVJW4VB1smg"

--bBA530V33nCN3VNlsEKFv4dVJW4VB1smg
Content-Type: multipart/mixed; boundary="6MlFD4gner2q11T9EeWS1T8S6qnGqjQik";
 protected-headers="v1"
From: Eric Blake <eblake@redhat.com>
To: cygwin@cygwin.com
Message-ID: <f38a6091-a097-baec-5f9b-927070cc4d5f@redhat.com>
Subject: Re: bug in lrint [was: FW: Printing long int in C program under
 cygwin64]
References: <d252aaae-b298-6fc8-7e5b-8d8be9f27f21@redhat.com>
 <592618e3.08179d0a.27b5e.4630@mx.google.com>
In-Reply-To: <592618e3.08179d0a.27b5e.4630@mx.google.com>


--6MlFD4gner2q11T9EeWS1T8S6qnGqjQik
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable

On 05/24/2017 06:36 PM, Steven Penny wrote:
> On Wed, 24 May 2017 07:33:27, Eric Blake wrote:
>> Buggy.  size_t should be printed with %zi, not %i (since size_t and int
>> are not necessarily the same type).
>=20
> Aren=E2=80=99t both wrong? By definition %i is a signed integer, and size=
_t is
> unsigned.
> So %zu

Correct.  Newer gcc's -Wformat-signedness will flag the discrepency.

> or %llu would be more correct:

NO. Do NOT use %llu with size_t, because it is not portable to 32-bit
platforms.  That's WHY %zu exists.

> They all seem to do the job though:

Yes. On all modern platforms, you can freely mix signed and unsigned
integers and get correct (when the number is positive and does not
exceed the signed maximum) or at least sane results (2s complement
counterpart for all other values) regardless of which direction you mess
with incorrect signedness.  However, such behavior is technically not
required by the C standard, which is why gcc added -Wformat-signedness.

--=20
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


--6MlFD4gner2q11T9EeWS1T8S6qnGqjQik--

--bBA530V33nCN3VNlsEKFv4dVJW4VB1smg
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJZJx+6AAoJEKeha0olJ0NqEmsH/1pMgmP41RJP4DSwXdg/29HJ
15OG6S9LKPJZ2KG0XFy5RNU/lu9ek4qbwXShqCR+i/ugtl0xWpTnDZN92PVmd8S1
br1+4tNYoUp57U+ZabLDBedgyTXZNnIUt/Vo6bvuPyW9w9BS6WzQURoSy5jnW8eZ
UM/iSBJDhZcduP6ww2inf7yZ4lOHo7McaKNpezs+pbiTxG3lKjynDMdG+ADz/Cjx
+dTK/RSnRKTDFLv4S1BICu8Zc+9MB+yV6c8+p/7/DjiUcDaQCTRcILt/nRcerdhu
gqlv2vTe5HN3J57+U4q5LrNd9IgEOQ4raNz+M/Rp5b0ohnBRbmHWlnA+OZ5nVaU=
=kuU9
-----END PGP SIGNATURE-----

--bBA530V33nCN3VNlsEKFv4dVJW4VB1smg--