DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:subject:to:references:from:message-id:date
	:mime-version:in-reply-to:content-type
	:content-transfer-encoding; q=dns; s=default; b=p8Oc+CsJ2BS2DJOJ
	OZ1271EHjsoZxYR5HWkgv6mMO9vICqW4WKzJioWXv5BYvT1wkhgLPN8FFYz1wjn0
	j9vABvfE/KHnjql7L/V1hkcpjHMG/OswezMfnXaaS+7qCO+SYzT7JNSEaldcAIiS
	A+uEqTHLaLuGMPQv2FTk7qi3Gs0=
Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm
Sender: cygwin-owner@cygwin.com
Mail-Followup-To: cygwin@cygwin.com
Subject: Re: borgbackup test fail on cygwin (only) - cygwin pipe issues?
To: cygwin@cygwin.com
References: <8d66dac6-689d-972f-d06a-f4c1869b6b87@waldmann-edv.de> <6d5d6289-ea61-cd18-fb48-c5053f292e0f@gmail.com>
From: Thomas Waldmann <tw@waldmann-edv.de>
Openpgp: id=6D5BEF9ADD2075805747B70F9F88FB52FAF7B393
Message-ID: <b6417df6-b205-2172-1af4-7422b25664f6@waldmann-edv.de>
Date: Thu, 12 Jan 2017 18:32:20 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <6d5d6289-ea61-cd18-fb48-c5053f292e0f@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

>> https://github.com/borgbackup/borg/issues/1268
> 
> Are your pipe handles in open in binary mode or text mode?  You should
> always ensure they are in binary mode.

That was my first idea also.

https://github.com/borgbackup/borg/blob/1.0.9/borg/remote.py#L188 this
is the place where the ssh subprocess is forked and the pipes are set up.

There is nothing special about binary mode there, but as mentioned in
that ticket, I just tried it out to send binary data over such pipes and
it worked:

https://github.com/borgbackup/borg/issues/1268#issuecomment-239923192

(that \n should get modified to \r\n if in text mode, but it got through
"as is")


-- 

GPG ID: 9F88FB52FAF7B393
GPG FP: 6D5B EF9A DD20 7580 5747 B70F 9F88 FB52 FAF7 B393


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple