DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:subject:to:references:from:message-id:date
	:mime-version:in-reply-to:content-type
	:content-transfer-encoding; q=dns; s=default; b=PIL9jLa3sLq3iDT1
	mjIZR45BreVAXyuRxLPIemupmoSeKDqI8zJXTtRKQPA/Xu1AiQ6HXfA7GgvhCQgN
	w3mDNhMw5VqLsmfgHQAaamnVkWsf1qrsHkq3lY38pqG6b7mPA6i8SxodHbMWVYeB
	jtJMrVwsmJszmQKCf0ac6U/PDmo=
Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm
Sender: cygwin-owner@cygwin.com
Mail-Followup-To: cygwin@cygwin.com
Subject: Re: Script broken after updating bash to 4.3.46-7?
To: cygwin@cygwin.com
References: <CAPTiy3PW0+bk20d30-J=sLr=PPnFOeU0Fb495hh1bBVtbtPrzw@mail.gmail.com> <CAPTiy3PXKi+8c+7VGOe+KMjqKmHAYfLERtsLcYKsz-5=C6nUaA@mail.gmail.com> <1635303092.20160827191501@yandex.ru>
From: cyg Simple <cygsimple@gmail.com>
Message-ID: <3ddc1bf3-7226-b163-fd51-cf0c22f850c7@gmail.com>
Date: Mon, 29 Aug 2016 09:07:03 -0400
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <1635303092.20160827191501@yandex.ru>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

On 8/27/2016 12:15 PM, Andrey Repin wrote:
> Greetings, Gene Pavlovsky!
> 
>> Looks like it's related to a recent change in bash, which is `read`
>> now honors Cygwin-specific `igncr` shell option (`set -o igncr`),
>> which I didn't enable.
>> Adding `set -o igncr` to the top of the script does the job, however
>> I'd like to know how many more scripts are potentially malfunctioning
>> now?
>> It's lucky that one sent e-mails on errors, some others might just
>> break silently.
>> Is it advisable to add `set -o igncr` to /etc/profile or SHELLOPTS? I
>> didn't use that feature before and am worried about some other
>> negative side effects.
> 
> It is advisable to not have CR's in your scripts to begin with.
> 

I thought this was about the data the script was reading and not the
script itself.  Data can have \r regardless of where in the data it
exists.  That said relying on defaults for a process has been taboo
since the dawn of computing.  Often defaults change on a whim, they are
bicycle shed colors, a maintainer may prefer blue instead of red in any
given release.  If your script requires a specific mode for the shell to
process data properly then be sure to set it before reading the data.

-- 
cyg Simple

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple