DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:from:to:cc:subject:date:message-id
	:content-type:content-id:content-transfer-encoding:mime-version;
	 q=dns; s=default; b=udknuBh1S1+71Jy2jd9QLOjX8Hi/ccafVq8dpILyGXK
	UmpbrvfF8DzrqAXq70ZIppNWBg+ZcONqNQqj6PA22a8wNo5H0DWIz6iamJDteVLR
	X+3wnuTsKQysp6PBKpBbFbMD5SsI2s/uL3bnn8D9Krt19/oryENHKE5V1iQv/nTg
	=
Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm
Sender: cygwin-owner@cygwin.com
Mail-Followup-To: cygwin@cygwin.com
From: Kevin Nomura <knomura@vmware.com>
To: "cygwin@cygwin.com" <cygwin@cygwin.com>
CC: Taylor Hutt <thutt@vmware.com>
Subject: spinlock.h timeout causing *** fatal error - add_item abort
Date: Fri, 29 Apr 2016 16:03:39 +0000
Message-ID: <D348D3EA.10AEB%knomura@vmware.com>
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
Content-Type: text/plain; charset="us-ascii"
Content-ID: <7D34DF49E9FC374B9229DB00873E37E4@vmware.com>
MIME-Version: 1.0
X-IsSubscribed: yes
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by delorie.com id u3TG4Ix4011256

Hi,

We occasionally see an api_fatal abort during process startup like:

*** fatal error - add_item ("somepath", "/", ...) failed, errno 1

This happens if mountinfo.init(false) in user_info::initialize is
called twice.  The error occurs on a second call when trying to add
the root mount point when it already exists.

mountinfo.init is guarded by a "spinlock" object that should only
allow one process to call it.  But the spinlock has a timeout.  After
15 seconds, it stops waiting and returns a value of 0.  The fatal
error can occur if two processes are starting around the same time
and the first process takes a long time in internal_getpwsid().  We've
seen this happen in our environment due to LDAP queries taking a long
time.  (Incidentally we are using msys, but code in spinlock.h and
shared.cc looks the same in cygwin).

To solve the aborts it is tempting to make a local fix to remove the
spinlock timeout.  I assume there was a rationale for it, and would
like to understand what tradeoff is incurred if we remove it.

- Kevin


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple