DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:content-type:mime-version:subject:from
	:in-reply-to:date:content-transfer-encoding:message-id
	:references:to; q=dns; s=default; b=KMssZpbPV6dd9OnUSnMrxIAlMrSE
	3r63ytYzK/v4tshDO1xBAm51UEPl7Kkre+WkcuhQs0i8IWbskfu9nsmhT7be52OE
	7fFxassuSvSbnd1h52dTiZS7XEXyWOk8IM7BdIVCT0TS/HPYh9Y0uOgh7E1QJyAp
	dv4K4V5DKNv7Ujk=
Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm
Sender: cygwin-owner@cygwin.com
Mail-Followup-To: cygwin@cygwin.com
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\))
Subject: Re: Problem with new acl code and cdrtools
From: Warren Young <wyml@etr-usa.com>
In-Reply-To: <CAFo71_4eQ2VMypAnC=Bx_bvbzGvVCs=jj4r9Ax6GDbgaH1zGOQ@mail.gmail.com>
Date: Mon, 8 Feb 2016 21:14:10 -0700
Message-Id: <CA0C06F1-A50D-4DBF-AB58-AADCE3D9F9F4@etr-usa.com>
References: <CAFo71_4fDB3WkhXTL7eybNzKh2idVF1UHb7oJjaxFshcS9BFUg@mail.gmail.com> <20160208131835.GC12975@calimero.vinschen.de> <CAFo71_5=KT=kJY-wz0EZWZ_LBriCjX2s6=5PSVhHRSxx-A92qg@mail.gmail.com> <56B8C25F.7050206@lysator.liu.se> <CAFo71_4eQ2VMypAnC=Bx_bvbzGvVCs=jj4r9Ax6GDbgaH1zGOQ@mail.gmail.com>
To: The Cygwin Mailing List <cygwin@cygwin.com>
Content-Transfer-Encoding: 8bit

On Feb 8, 2016, at 9:59 AM, Ismail Donmez <ismail@i10z.com> wrote:
> 
> On Mon, Feb 8, 2016 at 6:29 PM, Peter Rosin <peda@lysator.liu.se> wrote:
>> On 2016-02-08 14:31, Ismail Donmez wrote:
>>> This is a generic code so I don't want to add a cygwin specific
>>> dependency there. Is there a preprocessor definition for cygwin
>>> version? I could use that to disable HAVE_SUN_ACL for cygwin 2.5+
>> 
>> Pardon me for butting in, but isn't adding a Cygwin version check
>> about as non-generic as it gets?
>> 
>> Wouldn't something like this work:
>> 
>> .../configure ac_cv_func_aclfromtext=no
> 
> Thats a hack :)

I don’t know if that smiley means you’re joking or if you’re just trying to soften a negative judgement, but Peter’s proposal is as far from a hack as it gets.

He is proposing that you write an autoconf test that determines if the platform has this new ACL behavior.  Then in your C code:

   #include <config.h>
   #if HAVE_FUNC_ACLFROMTEXT
   #  include <cygwin/acl.h>
   #endif

Now you’re not dependent on Cygwin header file #defines that don’t exist yet, and will continue to not exist on older Cygwin installs.  You only include the Cygwin header if your autoconf test determines that this is necessary.

This is standard Autoconf practice: check for features, not for platforms or platform versions.  This practice comes from 40+ years of Unix portability experience, which is that platform and version tests often break, but feature tests rarely do.
--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple