X-Recipient: archive-cygwin@delorie.com DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:message-id:from:to:mime-version :content-transfer-encoding:content-type:in-reply-to:references :subject:date; q=dns; s=default; b=ZclLSYyaJWkkwsICuBRXMr/iyC1Cw XGaGHUO5a3o3oSqHESbLQ/5veqm5X8bEzI2AHQSOMkAm9HxsqdaQOjAlYvd3LJSq Ks3bOyt1USPNrNnSegw77ycSR0OJwyQFnTkQYhnzlfxJHYD4kEy91jLqydm77PsL jadRq/2JYLSYMc= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:message-id:from:to:mime-version :content-transfer-encoding:content-type:in-reply-to:references :subject:date; s=default; bh=4IYTpNVZglbDLoaHw+l6hCIFEaA=; b=QcJ /1/qGZpAVDRDx5UC69P6A7AlGHIA/IuJerKE97QZ7Cv0fSyP0hYdifL5besWR8Xr NJ/VpHNs6jivEa3rqoeZnRuk0sQqjcdC2cDpovrG+nK6WKHau9iT+rJBooOYKUa6 ooON0EdcM67oxKVEnhqANL1jfflY5ZhDLT8tyqVE= Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Delivered-To: mailing list cygwin@cygwin.com Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.7 required=5.0 tests=BAYES_20,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: out3-smtp.messagingengine.com Message-Id: <1445823930.241438.419951441.109BA262@webmail.messagingengine.com> From: Anthony Heading To: cygwin@cygwin.com MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain In-Reply-To: <1445135414.3384650.413058409.46BC94AD@webmail.messagingengine.com> References: <1445135414.3384650.413058409.46BC94AD@webmail.messagingengine.com> Subject: Re: mkshortcut (cygutils-1.4.14) free error Date: Sun, 25 Oct 2015 21:45:30 -0400 Hi, I see the cygutils package has been orphaned, perhaps explaining the lack of response to the below. A related question then is that the vanilla mkshortcut built from the latest source package does not seem to perfectly match the behaviour of the binary. Is there any way to review or reproduce how the binary package was built, or any other way to verify that the source and binaries do match? Thanks Anthony On Sat, Oct 17, 2015, at 10:30 PM, Anthony Heading wrote: > Seems free() is being called on an adjusted pointer, causing general > misbehaviour. A minimal patch below. > > Anthony > > > --- src/mkshortcut/mkshortcut.c.Orig 2015-10-17 21:57:08.000000000 > -0400 > +++ src/mkshortcut/mkshortcut.c 2015-10-17 22:16:41.269357400 -0400 > @@ -412,7 +412,7 @@ > char* exe_name = NULL; > char* dir_name = NULL; > char* desc = NULL; > - char *buf_str, *tmp_str; > + char *buf_str, *tmp_str, *base_str; > int tmp; > > /* For OLE interface */ > @@ -489,6 +489,7 @@ > { > /* Strip trailing /'s if any */ > buf_str = xstrndup (opts.target_arg, strlen(opts.target_arg)); > + base_str = buf_str; > tmp_str = buf_str; > tmp = strlen (buf_str) - 1; > while (strrchr (buf_str, '/') == (buf_str + tmp)) > @@ -504,7 +505,7 @@ > buf_str++; > } > link_name = xstrndup (tmp_str, strlen (tmp_str)); > - free (buf_str); > + free (base_str); > } > /* User specified a name, so check it and convert */ > else > > -- > Problem reports: http://cygwin.com/problems.html > FAQ: http://cygwin.com/faq/ > Documentation: http://cygwin.com/docs.html > Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple > -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple