DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:mime-version:in-reply-to:references:date
	:message-id:subject:from:to:content-type; q=dns; s=default; b=QV
	jltdmeMx1tNXWrpT+QmF0O3dCQxzIQYnsLzm2flEaz2XNpFuHuxVD5LeIEvb4MS+
	RBSinNP0KpxG2EDTekl1y+jkU6cmah5hki3zu7ZBWtXnRuUYUgNGDsicHhpb5Dut
	LQRlyRkOr1Xmn64dhwHfhUgt3uWvgd4OK4ihVq79U=
Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm
Sender: cygwin-owner@cygwin.com
Mail-Followup-To: cygwin@cygwin.com
MIME-Version: 1.0
In-Reply-To: <loom.20150801T222419-312@post.gmane.org>
References: <CAOC2fq_fahjLapKbgO8Xer8neEjv1Ohs4bM3JOWcka0ajjcbCg@mail.gmail.com>	<55BA373A.4020909@dronecode.org.uk>	<55BB6F47.1000906@dronecode.org.uk>	<CAOC2fq89HuStOLzEO9MxFZHBd54vmYfvp4juQyMKkNGkYG_D_g@mail.gmail.com>	<CAOC2fq-DHmzwkv5CcnqzQ-VG0fTy_5X0pnc6pPTWVbRvhOzaGQ@mail.gmail.com>	<loom.20150801T222419-312@post.gmane.org>
Date: Sat, 1 Aug 2015 18:55:01 -0700
Message-ID: <CAOC2fq8T0Ga0Xj_1R5RZ_Tog_JKc5_Dw23pomAFzUkVcC=ZxUg@mail.gmail.com>
Subject: Re: Analyzing a SEG FAULT that gdb doesn't help with
From: Michael Enright <mike@kmcardiff.com>
To: cygwin@cygwin.com
Content-Type: text/plain; charset=UTF-8

On Sat, Aug 1, 2015 at 1:28 PM, Brian Inglis  wrote:
>
> Seems like the problem may be developer confusion between strftime and
> printf conversion flag prefixes. The strftime space conversion flag
> character is _ so space filled seconds should use %_S, whereas the printf
> conversion flag character is space ' ', though I can't recall ever using
> that, as it is normally the default.
>
Well this code is not related to the strftime code in my other thread.
In this case it was just that a programmer didn't understand why
people do printf("%s",string) instead of printf(string). The program
takes lines out of log files, snarfs information out of them and makes
a report. Sometimes what belongs in the report is a copy of the entire
line from the log, so printf(line). But that would seem unwise in
general. In particular these log lines have prompts in them, and as
you know prompts often have '%' characters in them. It was only a
matter of time before this habit became a bad one.

So my email above is really the conclusion of the investigation, and
the fix is for me to switch the code to fputs in such cases.

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple