DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; q=dns; s=
	default; b=xY4+q37FTSt8TScqlCCuEBEHAWbMQKwCc1kaMY+D/2Sy0uqi2soJT
	u81Ngb7fyMP6n2zUAz0q9v1PX03OVz7JBVANS6aG7nA5p1JYQzDZul17r1C+4EGF
	SD2gNNN8VLwh3M14xM150b7NLgR4CSF7TEoFzf/4gA8/98rqZlaBEE=
Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm
Sender: cygwin-owner@cygwin.com
Mail-Followup-To: cygwin@cygwin.com
Date: Thu, 28 May 2015 16:16:12 +0200
From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin@cygwin.com
Subject: Re: cygwin-2 process handling
Message-ID: <20150528141612.GD27014@calimero.vinschen.de>
Reply-To: cygwin@cygwin.com
Mail-Followup-To: cygwin@cygwin.com
References: <1573487218.1490468.1431969356192.JavaMail.yahoo@mail.yahoo.com> <555B6F71.4040906@cornell.edu> <555B7E03.40404@cornell.edu> <20150521205357.2c125b3bcaf877d0843b52b1@nifty.ne.jp> <20150527122312.GF16927@calimero.vinschen.de> <20150527151734.GM16927@calimero.vinschen.de> <20150528114728.GA27014@calimero.vinschen.de> <20150528210932.3ffc9662998ff7ba9983990a@nifty.ne.jp> <20150528214409.269b5c2bc3eca9dbd888d032@nifty.ne.jp>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;	protocol="application/pgp-signature"; boundary="8nsIa27JVQLqB7/C"
Content-Disposition: inline
In-Reply-To: <20150528214409.269b5c2bc3eca9dbd888d032@nifty.ne.jp>
User-Agent: Mutt/1.5.23 (2014-03-12)

--8nsIa27JVQLqB7/C
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Takashi,

On May 28 21:44, Takashi Yano wrote:
> Hi Corinna,
>=20
> On Thu, 28 May 2015 21:09:32 +0900
> Takashi Yano wrote:
>=20
> > On Thu, 28 May 2015 13:47:28 +0200
> > Corinna Vinschen wrote:
> >=20
> > > I created another version of your patch which avoids duplicating the
> > > tested handle and makes the test-and-close-handle operation atomic:
> >=20
> > > Does that look ok?  It fixes the reported problem for me.
> >=20
> > Oops! I have just sent another patch.
>=20
> Your patch also works nicely for me.

I applied this patch.  I'm not comfortable with removing the SIGHUP
handling from slave::read in favor of just setting errno to EIO.
EIO seems wrong here.  Not being able to access the pipe anymore
should be equivalent to a hangup.  Alternatively the return code
from the Windows function should be checked for ERROR_BROKEN_PIPE,
perhaps, but that introduces some more code,


Thanks,
Corinna

--=20
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

--8nsIa27JVQLqB7/C
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJVZyMsAAoJEPU2Bp2uRE+g0uMP/ipyCa11FaidHu3E6BWUo0g3
flliKxHl/PPakgoenBi8Se/FDKF68oK4KsEnimINcgEOnnTuaNjc3U8kCKq//xs6
whdL13Do5v7oK3NUdx609fl5XcFVB0uMO5tngYmeyVQyi8EjovH7i5Mms5k3J4ol
LIOE5i7LKuAQjddfLhMrxp747aA0JUUinvP1V7EcMOerOOf3Uvp4oYDuw2G6hh6j
65eMglustEwFSJn1Ph+YDAeZT8uF/b+rnaRrmXNL1M96wj/HgbHw6s9idycd3VjO
Z5X576jcM9C50xZJOjMGcJVmVJzWHUgy8LScEtyA2IUXFXevRusgiew0XiTGxXrs
5kI3LB9TjwMuNQzt4qFReliqovM0E1vQK/8CL/VrYbJDXxGUWSrj8A/4aElCS+UL
rP5xnpwheo8be5XAyCJMLV8YU7+RfZ8gAkN7emurJu1CoG6hq4U1n5JZ3ZT45NFG
+3ioZ6PTvQLTUIife7UmnY3xfan9Uf0h2V9P7Nh/5oY4PlKenY8GBHE2ypNoQZHa
5KkOzORH4upoabid5wt4TD39DVg7VXBKuSyrhenGvErra3FILpa+CStF4dq42FcO
3FSK1eeYtUpxIjXlpdT0cAWe6KQOAKTBeIzQgt6i20ns2C+kk/Tx50cJGCrZmsxy
6dqW0AIOiBSqyYsFN6v+
=EBeE
-----END PGP SIGNATURE-----

--8nsIa27JVQLqB7/C--