DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:in-reply-to
	:references:mime-version:content-type:content-transfer-encoding;
	 q=dns; s=default; b=Wo9zK2Rad46k3fvcbrlfKqbten7cbn4datDYqJf7Avu
	kg9PD/474iete1evA7OI723V9gULaWR8VFRlpELE3C1myqdiuhFxALXtUbxktcgI
	7Dy5+fD76RKH12YVcjYlYS34uWiIHJDDAdU4xxQ9BLTDZ8F+2kZYHvJKnudrcu6k
	=
Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm
Sender: cygwin-owner@cygwin.com
Mail-Followup-To: cygwin@cygwin.com
Date: Wed, 25 Mar 2015 20:20:46 +0900
From: Takashi Yano <takashi.yano@nifty.ne.jp>
To: cygwin@cygwin.com
Subject: Re: TIOCPKT mode of PTY is broken if ONLCR bit is cleared.
Message-Id: <20150325202046.f6b6f40c0245145760d72391@nifty.ne.jp>
In-Reply-To: <20150323100823.GE3017@calimero.vinschen.de>
References: <20150228143653.ab0a6bf854db294105e1d5f3@nifty.ne.jp>	<20150228135947.GZ11124@calimero.vinschen.de>	<20150302210508.1be5c1ed4753508431842913@nifty.ne.jp>	<20150318145854.GC2368@calimero.vinschen.de>	<20150319074942.6c18c8fe0199037f028687dd@nifty.ne.jp>	<20150319083451.GA8398@calimero.vinschen.de>	<20150320191232.GJ2368@calimero.vinschen.de>	<20150321104031.9dc198eb8aa4e7652e0a7a51@nifty.ne.jp>	<20150323100823.GE3017@calimero.vinschen.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Hi Corinna,

On Mon, 23 Mar 2015 11:08:23 +0100
Corinna Vinschen <corinna-cygwin@cygwin.com> wrote:

> With this out of the way, I'm just looking through your patch and it
> looks good to me.  I have only a few minor style nits:
> 
> +                     rc ++;
> 
> No space between the variable and the increment operator, please.
> 
> +                 if ((get_ttyp ()->ti.c_oflag & ONOCR) && get_ttyp ()->column == 0)
> 
> Please try to keep lines <= 80 chars:
> 
> +                 if ((get_ttyp ()->ti.c_oflag & ONOCR)
> +                     && get_ttyp ()->column == 0)

Thank you for checking my patch. 

> However, due to the changes in fhandler_tty.cc, this patch doesn't
> apply cleanly anymore.  Any chance you could resend it (ideally to the
> cygwin-patches ML) diff'ed against git HEAD?

I will post a revised patch to cygwin-patches ML soon.

Thank you in advance.

-- 
Takashi Yano <takashi.yano@nifty.ne.jp>

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple