X-Recipient: archive-cygwin@delorie.com
DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; q=dns; s=
	default; b=OlUctRHJA47OPRkTXG/Mzp2raUQeNx2rbG9MxPQCZCDbI6k0+wkWi
	hTNc4I1hLors7pcbTkDb60Gy6IAjxOFciv2VlEXZLMRDoU1HFIsvj+cpryZJuKD1
	ouOxqWnnipynL8moHW9BD2ddAFc7ywnAEh7vj3oqSbuIqMwiappa3A=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:reply-to
	:references:mime-version:content-type:in-reply-to; s=default;
	 bh=Li5LzmlG7kd/KT2ZwxkIELHUk5k=; b=l7vlzj0qUw0NnxRoiKJ6U8fkPxn5
	yNrztJHZ8H+zv69KwXznkXbunU6vbhltX5Nw8Tp23nQzjxDH2PjkL9TMoGbEuJHd
	+JOmP5wjmnCNrka0WZZfe6F6zJEMRBTFB4boWmy3HvTMdHZXAF7YgIVHqVtsn9da
	+kAKF8t0CfpZXSQ=
Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm
List-Id: <cygwin.cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe@cygwin.com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin@cygwin.com>
List-Help: <mailto:cygwin-help@cygwin.com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner@cygwin.com
Mail-Followup-To: cygwin@cygwin.com
Delivered-To: mailing list cygwin@cygwin.com
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-5.9 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2
X-HELO: calimero.vinschen.de
Date: Mon, 23 Mar 2015 11:08:23 +0100
From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin@cygwin.com
Subject: Re: TIOCPKT mode of PTY is broken if ONLCR bit is cleared.
Message-ID: <20150323100823.GE3017@calimero.vinschen.de>
Reply-To: cygwin@cygwin.com
Mail-Followup-To: cygwin@cygwin.com
References: <20150228143653.ab0a6bf854db294105e1d5f3@nifty.ne.jp> <20150228135947.GZ11124@calimero.vinschen.de> <20150302210508.1be5c1ed4753508431842913@nifty.ne.jp> <20150318145854.GC2368@calimero.vinschen.de> <20150319074942.6c18c8fe0199037f028687dd@nifty.ne.jp> <20150319083451.GA8398@calimero.vinschen.de> <20150320191232.GJ2368@calimero.vinschen.de> <20150321104031.9dc198eb8aa4e7652e0a7a51@nifty.ne.jp>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;	protocol="application/pgp-signature"; boundary="+xNpyl7Qekk2NvDX"
Content-Disposition: inline
In-Reply-To: <20150321104031.9dc198eb8aa4e7652e0a7a51@nifty.ne.jp>
User-Agent: Mutt/1.5.23 (2014-03-12)

--+xNpyl7Qekk2NvDX
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Takashi,

On Mar 21 10:40, Takashi Yano wrote:
> Hi Corinna,
>=20
> On Fri, 20 Mar 2015 20:12:32 +0100
> Corinna Vinschen <corinna-cygwin@cygwin.com> wrote:
>=20
> > > For the time being, can you send your assignment as PDF via email
> > > to my company email address <vinschen AT redhat DOT com> just so
> > > we make sure it arrived in *some* way?
> >=20
> > Even better.  We got legal approval that we can use signed PDFs via
> > email alone, and that sending snail mail isn't required anymore.
> > Just sendthe PDF to <ges-info AT redhat DOT com>.
>=20
> Thank you very much for your effort for approving
> PDF copyright assignment.
>=20
> I have just sent it via e-mail.

And it's all set, finally.  Thanks a lot for not giving up on us :)

With this out of the way, I'm just looking through your patch and it
looks good to me.  I have only a few minor style nits:

+                     rc ++;

No space between the variable and the increment operator, please.

+                 if ((get_ttyp ()->ti.c_oflag & ONOCR) && get_ttyp ()->col=
umn =3D=3D 0)

Please try to keep lines <=3D 80 chars:

+                 if ((get_ttyp ()->ti.c_oflag & ONOCR)
+                     && get_ttyp ()->column =3D=3D 0)

However, due to the changes in fhandler_tty.cc, this patch doesn't
apply cleanly anymore.  Any chance you could resend it (ideally to the
cygwin-patches ML) diff'ed against git HEAD?


Thanks a lot,
Corinna

--=20
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

--+xNpyl7Qekk2NvDX
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBAgAGBQJVD+YXAAoJEPU2Bp2uRE+glm4QAIieveYI5y3HGkBiPPqV8WEz
GGUxHB6wcUI0RUIEtZUzWCZikmwtm/SqF0N78GrVvIyuRuByEnk0nQJ6FNj90R4r
PMYY8SKmgHzC23YwRlAv5klqfgzt2Slwyw/VM2Ktrgqic9w5l9Uwh641oyWUIN6C
/e10CXifa+aNmoM4J/5nC1/OH2jV1rHH+gXB4R+6Tj5LATip/3s/iJKkNCNP9fdR
mJ2TuPpkY1JNkpFOgtX4gwTjS5Cgo40S5Ztq8tbJuYkFy6bFj0yMWvTqOGqTKfcO
wsYDY+MWqof+NsnURmD/QAEDTy5Z8WAtzpyhVdquMoNbG7bh9QN1/+oMgJSIDY0j
BmUxnc1B3WsHwkm1XlU2iv25dpLe3bfQe3bY5OKYoLxjvkYdi+HwSU9pUd6GeMoK
tix+WlCZcKlbmvVkJYT1z1yu0OSBOYgr9zZQF1CZ+m44Go9EKgdLMdSFnqL5yYng
4rT/fL1KXKX1BQ56GboN1V2SbQXQ8qJIOxtbfGxp0mBvbYuEw9pPHjUDkJPnuKDE
GUGEa/qCD6lV7dN3aMqHngwktjp8PalS2n+ZC2svfc/MjlSSS5Vogn13GB4qeZpT
bkB8TznMM46eTgWM0TSiWqVtUCJgSATI8AjqGwh3VbMyzIqzFMY+vfOh3chdH3WR
T9Sw6z6Gd4ePMVwJ0VA2
=IEHZ
-----END PGP SIGNATURE-----

--+xNpyl7Qekk2NvDX--