DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:in-reply-to
	:references:mime-version:content-type; q=dns; s=default; b=lY06e
	OPjOUnSkJkAcj23PryYbSOPtfP6Zum78PJdITjSUE8Pj9NniC+Chg2n7MQJrFe9+
	ZeOk0pbCGSnCwCJLn65nMj94j80OM4ENh9Ghlz+YSmU3Fh9Ix5HmJRXAmTD3VqmT
	V6HjcyS//lrFJnk4LSL0/JtKsWPakOSA0Ut+YM=
Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm
Sender: cygwin-owner@cygwin.com
Mail-Followup-To: cygwin@cygwin.com
Date: Sun, 8 Mar 2015 16:37:59 +0900
From: Takashi Yano <takashi.yano@nifty.ne.jp>
To: cygwin@cygwin.com
Subject: Re: PTY dies when master in parent process is closed.
Message-Id: <20150308163759.9d3eacd5f3b168a1515a6bc2@nifty.ne.jp>
In-Reply-To: <20150306200710.1264a46aa8dd633943e56212@nifty.ne.jp>
References: <20150305215323.760df4752fdbd6f19a931851@nifty.ne.jp>	<20150305133100.GY3213@calimero.vinschen.de>	<20150305135839.GZ3213@calimero.vinschen.de>	<20150306200710.1264a46aa8dd633943e56212@nifty.ne.jp>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="Multipart=_Sun__8_Mar_2015_16_37_59_+0900_N6L9FRceyIKOw3Xo"

--Multipart=_Sun__8_Mar_2015_16_37_59_+0900_N6L9FRceyIKOw3Xo
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 6 Mar 2015 20:07:10 +0900
Takashi Yano <takashi.yano@nifty.ne.jp> wrote:

> On Thu, 5 Mar 2015 14:58:39 +0100
> Corinna Vinschen <corinna-cygwin@cygwin.com> wrote:
> 
> > I applied a patch.  Please have a look.
> 
> I have tested the latest CVS version, and found
> a new problem.
> 
> With new CVS version, slave side can not detect
> closure of master.
> 
> Please use following Test Case 3. Test Case 3 is
> not terminated by itself with latest CVS.
> 
> It seems that the program is stopping at
> cygwait(input_available_event, time_to_wait)
> in fhandler_pty_slave::read().
> 
> I guess input_available_event should be set when
> the last valid master fd is closed.

For this problem, I have made a patch.

With this patch, it has been confirmed that the problems
in Test Case 1, 2 and 3 are fixed.

I am glad if this would be a help.

However, one matter to be concerned is irregular use of
PeekNamedPipe(). Maybe alternative means could be better
for detecting closure of all master fds.


-- 
Takashi Yano <takashi.yano@nifty.ne.jp>

--Multipart=_Sun__8_Mar_2015_16_37_59_+0900_N6L9FRceyIKOw3Xo
Content-Type: application/octet-stream;
 name="cygwin.patch.20150308"
Content-Disposition: attachment;
 filename="cygwin.patch.20150308"
Content-Transfer-Encoding: base64

SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBm
aWxlOiAvY3ZzL3NyYy9zcmMvd2luc3VwL2N5Z3dpbi9DaGFuZ2VMb2csdgpy
ZXRyaWV2aW5nIHJldmlzaW9uIDEuNjY3MQpkaWZmIC11IC1wIC1yMS42Njcx
IENoYW5nZUxvZwotLS0gQ2hhbmdlTG9nCTUgTWFyIDIwMTUgMTM6NTg6MDIg
LTAwMDAJMS42NjcxCisrKyBDaGFuZ2VMb2cJNyBNYXIgMjAxNSAyMjo0Njoz
NiAtMDAwMApAQCAtMSwzICsxLDggQEAKKzIwMTUtMDMtMDggIFRha2FzaGkg
WWFubyA8dGFrYXNoaS55YW5vQG5pZnR5Lm5lLmpwPgorCisJKiBmaGFuZGxl
cl90dHkuY2MgKGZoYW5kbGVyX3B0eV9tYXN0ZXI6OmNsb3NlKTogQWRkIGNv
ZGUgdG8gbWFrZSBzbGF2ZQorCWRldGVjdCBjbG9zdXJlIG9mIG1hc3Rlci4g
Rml4IHR5cG8gaW4gZXJyb3IgbWVzc2FnZS4KKwogMjAxNS0wMy0wNSAgQ29y
aW5uYSBWaW5zY2hlbiAgPGNvcmlubmFAdmluc2NoZW4uZGU+CiAKIAkqIHR0
eS5oICh0dHk6OnNldF9tYXN0ZXJfY3RsX2Nsb3NlZCk6IFJlbmFtZSBmcm9t
IHNldF9tYXN0ZXJfY2xvc2VkLgpJbmRleDogZmhhbmRsZXJfdHR5LmNjCj09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvc3JjL3NyYy93
aW5zdXAvY3lnd2luL2ZoYW5kbGVyX3R0eS5jYyx2CnJldHJpZXZpbmcgcmV2
aXNpb24gMS4yOTIKZGlmZiAtdSAtcCAtcjEuMjkyIGZoYW5kbGVyX3R0eS5j
YwotLS0gZmhhbmRsZXJfdHR5LmNjCTUgTWFyIDIwMTUgMTM6NTg6MDIgLTAw
MDAJMS4yOTIKKysrIGZoYW5kbGVyX3R0eS5jYwk3IE1hciAyMDE1IDIyOjQ2
OjM2IC0wMDAwCkBAIC0xMzE3LDE3ICsxMzE3LDIxIEBAIGZoYW5kbGVyX3B0
eV9tYXN0ZXI6OmNsb3NlICgpCiAJfQogICAgIH0KIAorICBmaGFuZGxlcl9w
dHlfY29tbW9uOjpjbG9zZSAoKTsKKworICBpZiAoIVBlZWtOYW1lZFBpcGUg
KGZyb21fbWFzdGVyLCBOVUxMLCAwLCBOVUxMLCBOVUxMLCBOVUxMKQorICAg
ICAgJiYgR2V0TGFzdEVycm9yICgpID09IEVSUk9SX0JST0tFTl9QSVBFKSAK
KyAgICBTZXRFdmVudCAoaW5wdXRfYXZhaWxhYmxlX2V2ZW50KTsKKwogICBp
ZiAoIUZvcmNlQ2xvc2VIYW5kbGUgKGZyb21fbWFzdGVyKSkKICAgICB0ZXJt
aW9zX3ByaW50ZiAoImVycm9yIGNsb3NpbmcgZnJvbV9tYXN0ZXIgJXAsICVF
IiwgZnJvbV9tYXN0ZXIpOwogICBpZiAoIUZvcmNlQ2xvc2VIYW5kbGUgKHRv
X21hc3RlcikpCi0gICAgdGVybWlvc19wcmludGYgKCJlcnJvciBjbG9zaW5n
IGZyb21fbWFzdGVyICVwLCAlRSIsIHRvX21hc3Rlcik7CisgICAgdGVybWlv
c19wcmludGYgKCJlcnJvciBjbG9zaW5nIHRvX21hc3RlciAlcCwgJUUiLCB0
b19tYXN0ZXIpOwogICBmcm9tX21hc3RlciA9IHRvX21hc3RlciA9IE5VTEw7
CiAgIEZvcmNlQ2xvc2VIYW5kbGUgKGVjaG9fcik7CiAgIEZvcmNlQ2xvc2VI
YW5kbGUgKGVjaG9fdyk7CiAgIGVjaG9fciA9IGVjaG9fdyA9IE5VTEw7CiAK
LSAgZmhhbmRsZXJfcHR5X2NvbW1vbjo6Y2xvc2UgKCk7Ci0KICAgaWYgKGhh
dmVfZXhlY2VkIHx8IGdldF90dHlwICgpLT5tYXN0ZXJfcGlkICE9IG15c2Vs
Zi0+cGlkKQogICAgIHRlcm1pb3NfcHJpbnRmICgibm90IGNsZWFyaW5nOiAl
ZCwgbWFzdGVyX3BpZCAlZCIsIGhhdmVfZXhlY2VkLCBnZXRfdHR5cCAoKS0+
bWFzdGVyX3BpZCk7CiAgIGlmICghRm9yY2VDbG9zZUhhbmRsZSAoaW5wdXRf
YXZhaWxhYmxlX2V2ZW50KSkK


--Multipart=_Sun__8_Mar_2015_16_37_59_+0900_N6L9FRceyIKOw3Xo
Content-Type: text/plain; charset=us-ascii

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
--Multipart=_Sun__8_Mar_2015_16_37_59_+0900_N6L9FRceyIKOw3Xo--