DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:message-id:date:from:mime-version:to:subject
	:references:in-reply-to:content-type:content-transfer-encoding;
	 q=dns; s=default; b=Apaju+IufAFlEZ2dg8NWUAT1z36n2qsCoyPGVGj3L6O
	56jYQX/iUNJzvQxnZ7OCBmzdaO3wxVjyBHXsVzwu5SRE1sn9gq3Fi6zpqTfBe+pP
	E8E7bKFi1dcE6d4Jrr5Z1F355fKFpU+2+5cgw9FPPcZ4fVuB/3Mm9Ad9oJzLyliE
	=
Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm
Sender: cygwin-owner@cygwin.com
Mail-Followup-To: cygwin@cygwin.com
Message-ID: <5455114E.7050306@t-online.de>
Date: Sat, 01 Nov 2014 17:58:54 +0100
From: Christian Franke <Christian.Franke@t-online.de>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0 SeaMonkey/2.26.1
MIME-Version: 1.0
To: cygwin@cygwin.com
Subject: Re: [ANNOUNCEMENT] TEST RELEASE: Cygwin 1.7.33-0.4
References: <announce.20141029120845.GY20607@calimero.vinschen.de>
In-Reply-To: <announce.20141029120845.GY20607@calimero.vinschen.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Corinna Vinschen wrote:
> I just released a 4th TEST version of the next upcoming Cygwin release,
> 1.7.33-0.4.

There is an older regression in mkgroup.
A separator without a preceding domain name is printed for the builtin 
groups:

$ mkgroup -L THISHOST
SYSTEM:S-1-5-18:18:
TrustedInstaller:S-1-5-80-...
+Administratoren:S-1-5-32-544:544:
+Benutzer:S-1-5-32-545:545:
...
THISHOST+HelpLibraryUpdaters:S-1-5-21-...


Introduced in mkgroup.c CVS 1.54, April 2014:

@@ -415,8 +341,8 @@ enum_local_groups (...)
...
           printf ("%ls%s%ls:%s:%" PRIu32 ":\n",
-                 with_dom && !is_builtin ? domain_name : L"",
-                 with_dom && !is_builtin ? sep : "",
+                 mach->with_dom && !is_builtin ? domain_name : L"",
+                 mach->with_dom || is_builtin ? sep : "", <==== Hmm.... :-)


BTW: mkgroup should possibly also print the extra builtin groups which 
are now reported by getgroups(), for example 4(Interactive), 
11(Authenticated Users), ...
Groups with variable SIDs like LogonSession are an exception.

Christian


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple