DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:message-id:date:from:mime-version:to:subject
	:references:in-reply-to:content-type:content-transfer-encoding;
	 q=dns; s=default; b=gLRd+8wALlKJegSiafT+H2UexsvoWj77tdh3fNN4Z9R
	j+OrGvUpaNCwHe10Z56884AJ1/TLH3Jf+MsRPwI4KNhWMDTh7V0bqFkvGu96RpNO
	9AUsUlEI8gybU9Ev/nz1J5cCaD+KIAgR/+2TC4zAdVdxAjSk9019Wk5w4xUtaysM
	=
Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm
Sender: cygwin-owner@cygwin.com
Mail-Followup-To: cygwin@cygwin.com
Message-ID: <543D910D.3060003@cygwin.com>
Date: Tue, 14 Oct 2014 16:09:33 -0500
From: Yaakov Selkowitz <yselkowitz@cygwin.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0
MIME-Version: 1.0
To: cygwin@cygwin.com
Subject: Re: Crash in g_file_monitor on 32-bit Cygwin
References: <53AB82AB.5000304@cornell.edu> <53ADA5B5.10404@cornell.edu> <53ADAF68.2020703@cygwin.com> <53AEA23A.8030306@cornell.edu> <543D4ED3.6020605@cornell.edu> <543D6BB9.3030009@cornell.edu> <20141014192803.GE2681@calimero.vinschen.de>
In-Reply-To: <20141014192803.GE2681@calimero.vinschen.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 2014-10-14 14:28, Corinna Vinschen wrote:
> I know the code is not yours, but I have to vent while I see this code :)

Actually, this isn't the first time you're seeing this code, it's just 
been a while. :-)

> There's no reason to load GetVolumePathName from kernel32 since all supported
> platforms provide this entry point.

They didn't when this code was written.

> How old is this code?

2006.

> What *exactly* is this function trying to check?

gamin enforces permissions on its sockets, which will fail on FAT 
partitions for obvious reasons, so we need to bypass those checks in 
that case.

Obviously this code is overdue for an update, which I'll try to do later 
today.


Yaakov


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple