DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:message-id:date:from:reply-to:mime-version:to
	:subject:references:in-reply-to:content-type
	:content-transfer-encoding; q=dns; s=default; b=n1cD8mHiwelAE/Or
	90uiJNdSMy8I6xxx80fR9T+Kfy0JFzWFv83JXSbj7TzVCOgqjF+jL1RwEtcWwuXR
	GYyt50McrmEx9OMKSM/NiuqyBnKqw5AK5QKdGSR+seYIV3GtiZj95gp9TElzsh4X
	yFYGdwbZM5iRzTbc/nPXOe0THTA=
Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm
Sender: cygwin-owner@cygwin.com
Mail-Followup-To: cygwin@cygwin.com
Message-id: <53376E93.9050300@cygwin.com>
Date: Sat, 29 Mar 2014 21:08:35 -0400
From: "Larry Hall (Cygwin)" <reply-to-list-only-lh@cygwin.com>
Reply-to: cygwin@cygwin.com
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0
MIME-version: 1.0
To: cygwin@cygwin.com
Subject: Re: Public key authorization problem with latest snapshot
References: <5329B9D0.6070703@cornell.edu> <20140319160914.GD2715@calimero.vinschen.de> <5329C9EF.1000305@cornell.edu> <20140319170508.GF2715@calimero.vinschen.de> <885290127.20140320015843@yandex.ru> <20140320150258.GD3729@calimero.vinschen.de> <5336F3E3.5000402@cornell.edu> <20140329192928.GB4316@ednor.casa.cgf.cx>
In-reply-to: <20140329192928.GB4316@ednor.casa.cgf.cx>
Content-type: text/plain; charset=ISO-8859-1; format=flowed
Content-transfer-encoding: 7bit

On 3/29/2014 3:29 PM, Christopher Faylor wrote:
> On Sat, Mar 29, 2014 at 12:25:07PM -0400, Ken Brown wrote:
>> On 3/20/2014 11:02 AM, Corinna Vinschen wrote:
>>> On Mar 20 01:58, Andrey Repin wrote:
>>>> Greetings, Corinna Vinschen!
>>>>
>>>>> The code is now practically equivalent to what is in 1.7.28.  Only the
>>>>> VectoredContinueHandler, which was the reason Cygwin's exception handler
>>>>> could be called twice, is not called anymore.  Instead there's a vectored
>>>>> exception handler which is only called during debugging.
>>>>
>>>>> Before:
>>>>
>>>>>     if (!handler_installed)
>>>>>       {
>>>>>         handler_installed = true;
>>>>>         SetUnhandledExceptionFilter (handle);
>>>>>         AddVectoredContinueHandler (1, handle);
>>>>>       }
>>>>
>>>>> After:
>>>>
>>>>>     if (!handler_installed)
>>>>>       {
>>>>>         handler_installed = true;
>>>>>         SetUnhandledExceptionFilter (handle);
>>>>>         AddVectoredExceptionHandler (1, handle_while_being_debugged);
>>>>>       }
>>>>
>>>>> If anybody can explain this weird behaviour, please educate me.
>>>>
>>>> I can't explain the behavior, but I could say, that setting
>>>> "handler_installed = true;" before the handler is actually installed is not
>>>> quite right.
>>>> Unless that variable is used inside either of two functions called afterward,
>>>> I would move it down to the end of `if' block.
>>>
>>> BTDT.  This isn't the problem.  I *may* have found the culprit today,
>>> but I ripped apart a lot of the code so I'm not really sure yet.  Stay
>>> tuned.
>>
>> The problems I've reported seem to all be fixed in the latest snapshot
>> (2014-03-29 15:21:43 UTC).  Thanks!
>
> I'm sure Corinna will be happy to hear that.  She put in LONG hours
> getting that issue sorted out.
>
> I helped too, of course, by offering important "I don't like that
> implementation" style feedback.  It was one of those 50/50 collaborations
> where one person does all the work and the other person mentions it on
> a mailing list.

Sounds exhausting.  Perhaps you want to sit down.


-- 
Larry

_____________________________________________________________________

A: Yes.
 > Q: Are you sure?
 >> A: Because it reverses the logical flow of conversation.
 >>> Q: Why is top posting annoying in email?

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple