DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:message-id:date:from:mime-version:to:subject
	:references:in-reply-to:content-type:content-transfer-encoding
	:reply-to; q=dns; s=default; b=hl/RIuhzxP2aV4FG84t3tdOP8S3wnInsF
	FuSgckzeyA0FOA46jP7DWlKi9xvI0xc0cyc953n3ICjqPMiG1T6kl1KKKZeYUUyB
	hwk1VsD308rlv6IULDB8RcACZaKdRceJXFEh5G0vkp6gwQHAa9u7zMlnaUO6Mv8D
	jf8RmlSPHU=
Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm
Sender: cygwin-owner@cygwin.com
Mail-Followup-To: cygwin@cygwin.com
Message-ID: <52E42A1F.3010305@acm.org>
Date: Sat, 25 Jan 2014 13:18:23 -0800
From: David Rothenberger <daveroth@acm.org>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0
MIME-Version: 1.0
To: cygwin@cygwin.com
Subject: Re: Maintainer for git?
References: <CA+kUOanN3FjBzQ1HRPtmXfxLSbHps5WkkqrHqw8qK6FhX8aTgw@mail.gmail.com> <CAAXzdLV_xoMM59H_6fnTgRSAVhs4FLRaMyEL9e1WBzUp4SWR8g@mail.gmail.com> <CA+kUOakGhMYEP5kjmLk1HeWTi9QNTp1Fnk5YF3JuqR_fUc6hPg@mail.gmail.com> <20140115105534.GB31912@tastycake.net> <CAAXzdLX0YQTBVOkjUq3f-Jr03Cx5PzsY3_gRYO9rpp_GXOQKYw@mail.gmail.com> <CALgEz7qhf85-kdBCqFWWjni8rw8iTvabtdnBu=z4-tVmy_+jTg@mail.gmail.com> <CAAXzdLXQ-MfUQj6Zh4FSCgGgwwZ82OpkPTWznp5vVFXXeeKvHw@mail.gmail.com> <CALgEz7o7Sm2+NF=Fc3Wpp+Fy=+LQiz0aAc-+Pp+s=-Pjw--AuQ@mail.gmail.com> <CAM7Q9ZvnA4ukDXdbQExX7mje=6yx=0STzQTKAbWhG3jApGHmJw@mail.gmail.com> <20140123105142.GN2357@calimero.vinschen.de> <20140125115958.GU2357@calimero.vinschen.de>
In-Reply-To: <20140125115958.GU2357@calimero.vinschen.de>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Reply-To: cygwin@cygwin.com

On 1/25/2014 3:59 AM, Corinna Vinschen wrote:
> On Jan 23 11:51, Corinna Vinschen wrote:
>> On Jan 22 16:42, Chris O'Bryan wrote:
>>>> On Mon, Jan 20, 2014 at 5:31 PM, Steven Penny wrote:
>>>> 
>>>>> Are you certain the bug is present in Adam’s version? He
>>>>> has tested it here
>>>>> 
>>>>> http://cygwin.com/ml/cygwin/2014-01/msg00085.html
>>>> 
>>>> I just tried cloning something big again (the linux kernel).
>>>> See below. The first one was with git-1.7.9 the default
>>>> Cygwin version. [...] x86$ git clone
>>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>>>>
>>>> 
linux-git-1.8.5.2
>>>> Cloning into 'linux-git-1.8.5.2'... remote: Counting objects:
>>>> 3366700, done. remote: Compressing objects: 100%
>>>> (508113/508113), done. remote: Total 3366700 (delta 2833563),
>>>> reused 3362434 (delta 2829537) Receiving objects: 100%
>>>> (3366700/3366700), 703.64 MiB | 2.16 MiB/s, done. fatal: pack
>>>> is corrupted (SHA1 mismatch) fatal: index-pack failed [...]
>> 
>> Even if it's an OpenSSL issue, I'm not sure what to do about it.
>> I'm building OpenSSL for Cygwin, but I have no knowledge of the
>> crypto stuff...
>> 
>> I don't see anything unusual in the build process, except, maybe,
>> that for SHA1 the x86 assembler code is used.  I'm wondering what
>> happens when taking out -DSHA1_ASM from the build process.  Or
>> what happens when using -O2 instead of -O3.
> 
> I have a hunch that this is not a OpenSSL but a Cygwin problem.
> 
> The default case in OpenSSL is to use SSE2 instructions in the x86 
> assembler code.  However, SSE2 instructions utilize the x86 XMM 
> registers, which are not saved and restored in setjmp/longjmp, nor
> are they stored and restored in signal handling under Cygwin.
> 
> In the long run Cygwin should save and restore the XMM registers
> on x86 as well, I guess.
> 
> For the time being, I've build a new OpenSSL version 1.0.1f-2 with
> the "no-sse2" flag.  With this version I could clone the linx repo
> without error.  Please give it a try.

The new OpenSSL version fixes things for me. This explanation makes
sense given what I've seen as well.

I had built my own updated git binaries a while ago. I noticed that
for x86, the binaries would fail cloning a large repository, and would
also give spurious errors from "git fsck" on an existing repository. I
had no such problems with my x86_64 build.

With the new OpenSSL on x86, both the clone and the fsck problems have
gone away.

Thanks! Now my colleagues can use Git 1.8 with x86!


-- 
David Rothenberger  ----  daveroth@acm.org

Revolution, n.:
        In politics, an abrupt change in the form of misgovernment.
                -- Ambrose Bierce

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple