DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:message-id:date:from:mime-version:to:subject
	:content-type:content-transfer-encoding; q=dns; s=default; b=H8i
	H9Quswykjhv8f7Qjs2tj5Xb0cs6/RbCz1aYDogqx2g/4L8eVU+lUwWCc5JzlUxm/
	S5XgvKzQGCmUPXrYXdNnY6t4EcOyIHzfwJ+OO+z5hhkydFuLqOXcY3WMjceEBlNl
	A63sQcdahYo3XDXoinaYCwhCeJuQ7tPEKdNeUMJ4=
Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm
Sender: cygwin-owner@cygwin.com
Mail-Followup-To: cygwin@cygwin.com
Message-ID: <529AA451.4050408@gmail.com>
Date: Sat, 30 Nov 2013 21:52:01 -0500
From: Max Polk <maxpolk@gmail.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.1.1
MIME-Version: 1.0
To: Cygwin list <cygwin@cygwin.com>
Subject: [patch] cygwin-apps/run 1.0.3
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Follow-up to run 1.0.3 crashing and leaving run.exe.stackdump, first
reported at http://cygwin.com/ml/cygwin/2013-08/msg00169.html

The list wouldn't let me send a patch because it had an email address in
the Changelog, so I had to put it here: http://pastebin.com/4SSPDGQh

The first fix is much like the above, but instead simply changes < to <=
to also copy the extra NULL terminator sentinel in the argv array, which
was needed to avoid deleting random memory.

The second fix adds quotes around parameters so spaces in the original
arguments don't get mistaken as separate arguments.  For example this
original test case:

     run bash --login -i -c "emacs FILENAME"

Get executed internally within run as this without quotes:

     bash --login -i -c emacs FILENAME

Without reinstating the quotes emacs runs with no arguments and FILENAME
is lost by bash.

Debug output (--run-debug=3) excerpt from two commands showing how
quotes are now added:

run DEBUG: C:\Apps\Cyg\bin\bash.exe --login -i -c emacs FILENAME

run DEBUG: C:\Apps\Cyg\bin\bash.exe "--login" "-i" "-c" "emacs FILENAME"

Side note: If you ask me why I'm running bash as a login shell to run
emacs-w32, it's to get all my .bash_profile settings when launched from
a Windows shortcut.  Paths and env vars and other things work better.
The side effect is that bash is a parent of emacs-w32 but that's okay
because there is no console window.


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple