DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:message-id:date:from:mime-version:to:subject
	:references:in-reply-to:content-type:content-transfer-encoding;
	 q=dns; s=default; b=L01TxpLavVuHRFFcHOLAECQaEW80zzXoGRUkcPKpKUf
	oJSiQpXDiPhFMvpHwLm1F4YKdDThhXxp7ym942wztBDBYoNRwyw7xsfiR/JEFC2h
	X5VqIlkp50yeps0Brm69TS9GUejVAY1w2PinQEs8A6ALViVO4Fjw/Qf+gO4fr0FY
	=
Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm
Sender: cygwin-owner@cygwin.com
Mail-Followup-To: cygwin@cygwin.com
Message-ID: <5208EF91.7070504@cwilson.fastmail.fm>
Date: Mon, 12 Aug 2013 10:22:09 -0400
From: Charles Wilson <cygwin@cwilson.fastmail.fm>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7
MIME-Version: 1.0
To: The Cygwin Mailing List <cygwin@cygwin.com>
Subject: Re: Patch for run-1.3.0-1 core dump
References: <CAOJ7xCsuuhNmtz_ybGJoEeUAdWhJ1Y3+9d5mBtATH-F=VpkYGg@mail.gmail.com>
In-Reply-To: <CAOJ7xCsuuhNmtz_ybGJoEeUAdWhJ1Y3+9d5mBtATH-F=VpkYGg@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

On 8/10/2013 1:34 PM, foo wrote:
> Whenever I execute run.exe, it generates run.exe.stackdump.
>
> At line 370 in run.c, run2_freeargv() tries to free newargv, and
> run2_freeqrgv() expects that newargv is terminated by NULL. However,
> in shifting newargv at line 253-256, it fails to shift NULL
> terminator. Therefore, run2_freeargv() frees memory illegally.
> The following patch is a workaround.
>
> --- run.c.old
> +++ run.c.new
> @@ -252,7 +252,7 @@
>         newargv = run2_dupargv (argv);
>         /* discard newargv[0] and shift up */
>         free (newargv[0]);
> -      for (newargc = 1; newargc < argc; newargc++)
> +      for (newargc = 1; newargv[newargc-1] != NULL; newargc++)
>            newargv[newargc-1] = newargv[newargc];
>         newargc = argc - 1;

Thanks for the bug report and the patch. I'll investigate and update the 
package soon.

--
Chuck


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple