DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:date:from:to:subject:message-id:reply-to
	:references:mime-version:content-type:content-transfer-encoding
	:in-reply-to; q=dns; s=default; b=MHgD7ItjiJxf+aU3wJjvJYC9INJ8kc
	8+jyFHRbYP1AOAnMyIuS36kyNeRxIg+ExMgjGa/z7W1yno4jIRySUgoIH3oJL7/c
	DebCSdlijpY7iuLORjupEEXEHpN78F+PPp7LZk1M7hxhtDib8W5wEO/9LlzlybBy
	e9J31hiFIVTC0=
Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm
Sender: cygwin-owner@cygwin.com
Mail-Followup-To: cygwin@cygwin.com
Date: Wed, 17 Jul 2013 16:10:42 +0200
From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin@cygwin.com
Subject: Re: Issue with run.exe and PWD with spaces since last update (Cygwin 1.7.21)
Message-ID: <20130717141042.GE32258@calimero.vinschen.de>
Reply-To: cygwin@cygwin.com
Mail-Followup-To: cygwin@cygwin.com
References: <295777180.20130716202913@mtu-net.ru> <20130717125916.GB21347@calimero.vinschen.de> <51E69DE2.10008@cwilson.fastmail.fm> <20130717134532.GC32258@calimero.vinschen.de> <51E6A3DB.7050605@cwilson.fastmail.fm>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <51E6A3DB.7050605@cwilson.fastmail.fm>
User-Agent: Mutt/1.5.21 (2010-09-15)

On Jul 17 10:02, Charles Wilson wrote:
> On 7/17/2013 9:45 AM, Corinna Vinschen wrote:
> >On Jul 17 09:36, Charles Wilson wrote:
> >>Could we add a new cygwin_internal routine that triggers the
> >>allocation, creation and return of a suitable single-line command?
> >>Then run & friends could do (pseudo-code):
> 
> >That should be unnecessary.  The culprit here is the default main
> >routine in cygwin's libcmain.c, which calls WinMain if the executable
> >doesn't provide its own main.
> >
> >It doesn't construct the single-line commandline from argv, but rather
> >it calls GetCommandLinė.  This, obviously, creates an empty command line
> >for WinMain.
> >
> >So, the actual fix is to change libcmain's main() routine to create
> >WinMain's cmdline arg from argc/argv.
> 
> Ack.
> 
> >However, either way, you will have to rebuild run/run2 for both
> >architectures since libcmain.c is linked statically to the executable.
> 
> Right.
> 
> >So, if we do it this way, we should probably upload a new Cygwin DLL
> >with the patched libcmain ASAP, so you can rebuild against the new
> >libcmain.  Or, actually it would be better you would test this as soon
> >as we made the patch, *before* releasing a new Cygwin DLL.
> 
> NP. Both of those packages have been recently rebuilt, so they are
> "up to date" with regard to the (relatively recent) w32api and
> cygport improvements; it's just a simply rebuild with no other
> changes.
> 
> >Anyway, if we do it that way, let's hope no other tool is doing the
> >same...
> 
> Seems pretty unlikely to me. Most cygwin apps derive from a unix or
> traditional programming model heritage, and use main(). Very few
> would seem to derive from a Win32 heritage with WinMain() (why
> bother? just run the native program instead of porting a windows app
> to cygwin).

Uhm.  In that case, if ew *really* think your tools are the only
affected ones, Why do we bother to fix libcmain.c?  Can't you then
simply provide your own main() in case of building for Cygwin?


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple