DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:mime-version:in-reply-to:references:date
	:message-id:subject:from:to:content-type
	:content-transfer-encoding; q=dns; s=default; b=W2+zwPbcEbFVE4SB
	FtOwaY+Rnk5kkR5lC3527f4wLddoByNvAXxJP5il0D9etb3ZFHinsEz3FDgtJo4i
	r/6ef9Hwe13Co2K8H8SXVH2cIE6BMwsSzHDAuIAMYMOynh5ccoApRC/+28d8CywK
	JlzN/K/xb5FvvQY2doIS/U9Ymg0=
Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm
Sender: cygwin-owner@cygwin.com
Mail-Followup-To: cygwin@cygwin.com
MIME-Version: 1.0
In-Reply-To: <20130619101227.GL1620@calimero.vinschen.de>
References: <CABEPuQJDLjtbcLig1isTUJgb6RBCD8LNShbm9mTPcb9WM5S5fw@mail.gmail.com>	<51C0B08E.8080900@etr-usa.com>	<CABEPuQJJpRfPKSwZ7M0eTOdp1HxDcmvuy1=qXFHBw-8kLkZ1ZQ@mail.gmail.com>	<51C0D956.4090905@etr-usa.com>	<20130619020234.GA3669@ednor.casa.cgf.cx>	<CABEPuQKtytz=Yjw=-S4LOKm8VGCOfa3hSgdpnhkxaWye1GoVaQ@mail.gmail.com>	<20130619101227.GL1620@calimero.vinschen.de>
Date: Wed, 19 Jun 2013 15:04:38 +0400
Message-ID: <CABEPuQJF51dJ72mv=A_MS3AOR8Lq_Htt9=D98fB_xSB3jCszEA@mail.gmail.com>
Subject: Re: Adding MSYS functionality to Cygwin
From: Alexey Pavlov <alexpux@gmail.com>
To: cygwin@cygwin.com
Content-Type: text/plain; charset=KOI8-R
Content-Transfer-Encoding: 8bit

2013/6/19 Corinna Vinschen :
> On Jun 19 10:53, Алексей Павлов wrote:
>> Today I investigate in this direction and find that logic works well
>> except one line in spawn.cc that I think can be fixed without break
>> anything.
>>
>> Index: cygwin/spawn.cc
>> ===================================================================
>> RCS file: /cvs/src/src/winsup/cygwin/spawn.cc,v
>> retrieving revision 1.345
>> diff -u -p -r1.345 spawn.cc
>> --- cygwin/spawn.cc 3 May 2013 19:39:01 -0000 1.345
>> +++ cygwin/spawn.cc 19 Jun 2013 05:53:36 -0000
>> @@ -406,7 +406,7 @@ child_info_spawn::worker (const char *pr
>> }
>> else
>> {
>> - if (wascygexec)
>> + if (real_path.iscygexec ())
>
> Line 374:
>
>   wascygexec = real_path.iscygexec ();
>
> Do you have an example why your change should make a difference?
>
My opinion is next:
wascygexec is initialized before calling av::fixup that determine is
executable depends on Cygwin1.dll and always (for me) is 0. But in
av::fixup real_path.iscygexec () can be changed.
And code always go to condition with one_line.fromargv.

Regards, Alexey.

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple