From: "Lavrentiev, Anton (NIH/NLM/NCBI) [C]" <lavr@ncbi.nlm.nih.gov>
To: "cygwin@cygwin.com" <cygwin@cygwin.com>
Subject: RE: Possible race in SYSV IPC (semaphores)
Date: Fri, 23 Nov 2012 17:16:02 +0000
Message-ID: <5F8AAC04F9616747BC4CC0E803D5907D0162C6@MLBXv04.nih.gov>
References: <5F8AAC04F9616747BC4CC0E803D5907D012856@MLBXV09.nih.gov> <20121123113605.GN17347@calimero.vinschen.de> <20121123131020.GR17347@calimero.vinschen.de> <20121123133332.GU17347@calimero.vinschen.de> <20121123164404.GX17347@calimero.vinschen.de>
In-Reply-To: <20121123164404.GX17347@calimero.vinschen.de>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm
Sender: cygwin-owner@cygwin.com
Mail-Followup-To: cygwin@cygwin.com
Content-Transfer-Encoding: 8bit

> This should avoid the race (*and* work...)
> Please give it a try.

Thanks!  I've tried both patches (pipe race + semadj), and they do seem to work!

Although (not being a party pooper :-), I think that all the logic
around "pipe_instance" can now be dropped entirely, and benefit from eliminating
an unnecessary synchronization point (pipe_instance is now only used
for logging a proper pipe ID, which is not even seen in regular use,
and for an assert(), which again is only there in debug mode builds).
So there is no need to arrange Enter'ing/Leave'ing of the critical section
to do just the hidden things, yet the working code would be a bit cleaner.

Anton Lavrentiev
Contractor NIH/NLM/NCBI