Message-ID: <50834F0F.4050303@users.sourceforge.net>
Date: Sun, 21 Oct 2012 09:25:35 +0800
From: JonY <jon_y@users.sourceforge.net>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.12) Gecko/20080213 Thunderbird/2.0.0.12 Mnenhy/0.7.5.0
MIME-Version: 1.0
To: cygwin@cygwin.com
Subject: Re: w32api-headers-3.0b_svn5431-1: _WIN32 no longer set on Cygwin
References: <5082A321.1050601@t-online.de>	<5082CF13.8090701@users.sourceforge.net> <CAEwic4a+9XeGwqOxs3_hJA3vp=oAYGhwUpt4n6anj_TLG36o6Q@mail.gmail.com> <5082E008.10105@t-online.de>
In-Reply-To: <5082E008.10105@t-online.de>
Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig3303FDBF943895928B43E0AD"
Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm
Sender: cygwin-owner@cygwin.com
Mail-Followup-To: cygwin@cygwin.com

--------------enig3303FDBF943895928B43E0AD
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On 10/21/2012 01:31, Christian Franke wrote:
> Kai Tietz wrote:
>> 2012/10/20 JonY wrote:
>>> On 10/20/2012 21:12, Christian Franke wrote:
>>>> Just for Info:
>>>>
>>>> The new /usr/include/w32api/windef.h does no longer define _WIN32.
>>>>
>>>> This may require compile fixes for some sources which check only for
>>>> _WIN32 and not for __CYGWIN__ after windows.h is included.
>>>>
>>>> Christian
>>> I can't imagine why you'd include windows.h and then check for _WIN32
>>> after the fact, but I still think mixing win32 calls and Cygwin calls is
>>> a bad idea, except for a few special cases.
>>>
>>> Anyway, I'll leave it to Kai to decide if it should be done, as I'm not
>>> sure if this request is proper.
>> That we don't define _WIN32 - actual we do internally but don't show
>> it to includer - is done by intention.  Actual Corinna and I decided
>> that this behavior is for cygwin the desired.
>=20
> For the long term, it was IMO a good decision to change (fix) the old
> behavior.
>=20
> For now, some (trivial) fixes to existing code may be required. I built
> the smartmontools-6.0-1 Cygwin package a few hours before the new
> headers were uploaded. Build from source package does no longer work
> with new headers (unfortunately the foreign CSMI include file requires
> _WIN32).
>=20
> Christian

I suppose the following is fine too in smartmontools:

#define _WIN32
#include <windows.h>


--------------enig3303FDBF943895928B43E0AD
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (MingW32)

iEUEARECAAYFAlCDTxQACgkQp56AKe10wHfIHACY0ZZ0lyE7ME+B4wnAVVWEQZ7R
jACeKpK0sO5VFx+54ehUZPRJq+7wARM=
=bGYe
-----END PGP SIGNATURE-----

--------------enig3303FDBF943895928B43E0AD--