X-Recipient: archive-cygwin@delorie.com X-SWARE-Spam-Status: No, hits=-2.8 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD,UNPARSEABLE_RELAY X-Spam-Check-By: sourceware.org Message-ID: <5082E008.10105@t-online.de> Date: Sat, 20 Oct 2012 19:31:52 +0200 From: Christian Franke User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/20120826 Firefox/15.0 SeaMonkey/2.12 MIME-Version: 1.0 To: cygwin@cygwin.com Subject: Re: w32api-headers-3.0b_svn5431-1: _WIN32 no longer set on Cygwin References: <5082A321.1050601@t-online.de> <5082CF13.8090701@users.sourceforge.net> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Delivered-To: mailing list cygwin@cygwin.com Kai Tietz wrote: > 2012/10/20 JonY wrote: >> On 10/20/2012 21:12, Christian Franke wrote: >>> Just for Info: >>> >>> The new /usr/include/w32api/windef.h does no longer define _WIN32. >>> >>> This may require compile fixes for some sources which check only for >>> _WIN32 and not for __CYGWIN__ after windows.h is included. >>> >>> Christian >> I can't imagine why you'd include windows.h and then check for _WIN32 >> after the fact, but I still think mixing win32 calls and Cygwin calls is >> a bad idea, except for a few special cases. >> >> Anyway, I'll leave it to Kai to decide if it should be done, as I'm not >> sure if this request is proper. > That we don't define _WIN32 - actual we do internally but don't show > it to includer - is done by intention. Actual Corinna and I decided > that this behavior is for cygwin the desired. For the long term, it was IMO a good decision to change (fix) the old behavior. For now, some (trivial) fixes to existing code may be required. I built the smartmontools-6.0-1 Cygwin package a few hours before the new headers were uploaded. Build from source package does no longer work with new headers (unfortunately the foreign CSMI include file requires _WIN32). Christian -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple