X-Recipient: archive-cygwin@delorie.com
X-SWARE-Spam-Status: No, hits=-5.1 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=google.com; s=20120113;        h=mime-version:in-reply-to:references:date:message-id:subject:from:to         :content-type:x-system-of-record:x-gm-message-state;        bh=97lcPXFa8uI4fJF/A+FGAuKMpZqRQk9yh0YokLMV9UQ=;        b=ZKDnjt80FC9t9MVT8FEFAyJIR2i3h5bGpUl73WCMrfslNwLGnyc6TjBC1paPxipOhM         pYiNsG8cV7JxyPIa1y3FjnDDOEWkHD2O3qszHPDRnDAAxkQEGF5cR1jUGIaGlEx5IpPP         KxgK6u5u6BHISRKomPJfbL0ys+HnGpTAg75XvZNm9esTusA4gxiZHQs2WZFtPFDhjChl         yZ8+ibhDCu2uYUJphlEKRbzPIrrDAmdzSAnR83KQA6dByHaZ8/wtgTwvo1lD+2f0Cwmw         um357O1Ts3hm+hPHvZ+x+GwAsjInRHd/qps8sLKNPMkd8KbE5Jmwco8IWECYbtk/D2hR         rYEQ==
MIME-Version: 1.0
In-Reply-To: <CACgPhYrxk8_DvbZ44afZ9OrLTvXHn1-geyuL2EpfPWeeDG1yZw@mail.gmail.com>
References: <CACgPhYrxk8_DvbZ44afZ9OrLTvXHn1-geyuL2EpfPWeeDG1yZw@mail.gmail.com>
Date: Mon, 17 Sep 2012 13:00:33 +0400
Message-ID: <CACgPhYpKsAAvXdtKJN=v7V=Qenh=MiTGixtfxBxrRHt2p+nTSQ@mail.gmail.com>
Subject: Re: Cygwin crashes in kill_pgrp, _pinfo truncation issue.
From: Andrey Khalyavin <halyavin@google.com>
To: cygwin@cygwin.com
Content-Type: text/plain; charset=ISO-8859-1
X-System-Of-Record: true
X-Gm-Message-State: ALoCoQm7xiHGBxddQvdxFn9lwDHZSGR/t+OZEPzBWwTdHrdZ2NKhjaGNQ3JmNI8u5yr8XB253djtzrdzOiZ7cZI8F8yCAs+A1sIuS7gDIt91QKsfw3/DFeEiGFEsgE4wWmbKMSgnanV2hXZY7IBNQowmEmzp+GL39R4DYZ9EqeCvn9d6/A141uj6LnTEsAtQ8IXQ4UTs57ru
Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm
Precedence: bulk
List-Id: <cygwin.cygwin.com>
List-Unsubscribe: <mailto:cygwin-unsubscribe-archive-cygwin=delorie.com@cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe@cygwin.com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin@cygwin.com>
List-Help: <mailto:cygwin-help@cygwin.com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner@cygwin.com
Mail-Followup-To: cygwin@cygwin.com
Delivered-To: mailing list cygwin@cygwin.com

2012/8/23 Andrey Khalyavin wrote:
>
> I got two more crash dumps from our bots running 20120816 snapshot.
> Both of them crashed in this place. process_state equals to
> PID_IN_USE | PIE_EXECED and your new check in _pinfo::exist is really there.
> So the race condition on process_state field does happens in practice.
>
> Andrey Khalyavin

I removed _pinfo truncation optimization and now all crashes are gone.

Andrey Khalyavin

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

