X-Recipient: archive-cygwin@delorie.com X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,SPF_NEUTRAL,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Message-ID: <4FD90105.7050701@cornell.edu> Date: Wed, 13 Jun 2012 17:07:17 -0400 From: Ken Brown User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: cygwin@cygwin.com Subject: Re: Performance problems with emacs-X11 in current cygwin References: <4FC7D9E6.5050609@alice.it> <4FCA1FF0.8090703@alice.it> <4FCA2CA9.7080704@cornell.edu> <4FCA634D.1080206@cornell.edu> <4FCB2991.3010701@users.sourceforge.net> <4FCB5438.7080903@cornell.edu> <4FCB9872.5010506@cornell.edu> <4FD1F709.4050107@cornell.edu> <87k3zhbyyk.fsf@Rainer.invalid> <4FD22C39.6070107@cornell.edu> <4FD53FA9.2040105@cornell.edu> <4FD8DE9C.1090900@cornell.edu> In-Reply-To: <4FD8DE9C.1090900@cornell.edu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-PMX-CORNELL-SPAM-CHECKED: Pawpaw X-Original-Sender: kbrown@cornell.edu - Wed Jun 13 17:07:21 2012 X-PMX-CORNELL-REASON: CU_White_List_Override X-IsSubscribed: yes Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Delivered-To: mailing list cygwin@cygwin.com On 6/13/2012 2:40 PM, Ken Brown wrote: > On 6/10/2012 8:45 PM, Ken Brown wrote: >> The bisection shows that the first problematic commit is this one: >> >> http://git.gnome.org/browse/glib/commit/?h=glib-2-32&id=7eae486179e2799c369ed9ffcea663bf9161ce79 >> >> >> >> Author: Ryan Lortie >> Date: Wed Aug 31 22:07:02 2011 -0400 >> >> GMain: simplify logic for g_wakeup_acknowledge() >> >> Instead of messing around with context->poll_waiting, just look at the >> GPollFD to see if the GWakeup needs to be acknowledged. > > I think this commit contains a typo: "events" should be "revents". > (context->wake_up_rec.events is always nonzero at this point in the > code, so it makes no sense to test that.) As a result, > g_wakeup_acknowledge() is being called much more often than necessary. I > think this could easily explain the performance problems that have been > reported, but I won't have a chance to test this on my (slow) XP system > for a while, and possibly not until tomorrow. I've confirmed that fixing the typo solves the problem on my XP system. I suspect that this issue is not specific to XP after all and has more to do with the slowness of the machine, so that the performance problem is more noticeable. In any case, it's clearly a glib bug. I've filed a bug report upstream: https://bugzilla.gnome.org/show_bug.cgi?id=678052 Ken -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple