X-Recipient: archive-cygwin@delorie.com X-Spam-Check-By: sourceware.org Date: Tue, 28 Feb 2012 11:24:26 +0100 From: Corinna Vinschen To: cygwin@cygwin.com Subject: Re: 'more' segment faults with latest cygwin1.dll (1.7.11) Message-ID: <20120228102426.GF23052@calimero.vinschen.de> Reply-To: cygwin@cygwin.com Mail-Followup-To: cygwin@cygwin.com References: <20120227195959.GC7534@calimero.vinschen.de> <1330384952.6720.20.camel@YAAKOV04> <20120228081859.GA23052@calimero.vinschen.de> <1330422189.404.18.camel@YAAKOV04> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1330422189.404.18.camel@YAAKOV04> User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Delivered-To: mailing list cygwin@cygwin.com On Feb 28 03:43, Yaakov (Cygwin/X) wrote: > On Tue, 2012-02-28 at 09:18 +0100, Corinna Vinschen wrote: > > It's a bug in more, afaics. In case of pressing 'n', the search function > > is called with a NULL buf argument. However, the function calls > > strlen(buf) without checking buf for NULL. The indentation at this > > point in the file looks like this `if (strlen(buf) > 0) {' has been > > added as a kind of patch. > > Yes, I had to patch more(1) to use regcomp/regexec instead of > re_comp/re_exec, which we don't have on Cygwin. With your clarification > I should be able to fix it easily. Just an idea, instead of working around them, why not just add them to the lib? You could copy the FreeBSD implementation which just implements them in terms of the regcomp/regexec API: http://www.freebsd.org/cgi/cvsweb.cgi/~checkout~/src/lib/libcompat/4.3/re_comp.c?rev=1.1;content-type=text%2Fplain Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Project Co-Leader cygwin AT cygwin DOT com Red Hat -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple