Message-ID: <4D83017B.2070607@cwilson.fastmail.fm>
Date: Fri, 18 Mar 2011 02:53:47 -0400
From: Charles Wilson <cygwin@cwilson.fastmail.fm>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.8.1.23) Gecko/20090812 Thunderbird/2.0.0.23 Mnenhy/0.7.6.666
MIME-Version: 1.0
To: cygwin@cygwin.com
Subject: Re: ITP dos2unix 5.2.1-1
References: <4D7FE2A7.8080409@xs4all.nl> <4D7FE57A.4020903@redhat.com> <4D806DCF.5090803@xs4all.nl> <4D80C0B8.8090603@cwilson.fastmail.fm> <4D80CEB4.7090005@xs4all.nl> <20110316154913.GA18995@ednor.casa.cgf.cx> <4D80DEAF.6020307@xs4all.nl> <4D810FAF.6040609@t-online.de> <20110316193249.GA15365@ednor.casa.cgf.cx> <4D8117FD.40507@cwilson.fastmail.fm> <20110316201821.GA773@ednor.casa.cgf.cx> <4D812DBE.1090607@cwilson.fastmail.fm> <4D81CED1.9050601@xs4all.nl> <4D820D62.4030403@cwilson.fastmail.fm> <4D821D89.5020105@xs4all.nl> <4D823D92.1000600@cwilson.fastmail.fm> <4D826761.5030302@xs4all.nl> <4D826A52.8090009@redhat.com> <4D8270BB.9010608@cwilson.fastmail.fm>
In-Reply-To: <4D8270BB.9010608@cwilson.fastmail.fm>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm
Sender: cygwin-owner@cygwin.com
Mail-Followup-To: cygwin@cygwin.com

On 3/17/2011 4:36 PM, Charles Wilson wrote:
> OK, everybody, time out for a minute.  Rather than talk vapor, I'll
> develop the patches necessary.

Fair warning: I've developed this patch set, and made a cygport-based
package...but I have NOT TESTED the apps at all.  More later, but it's
way past my bed time...

> The first one, or first set (e.g. #2, above), I'll propose that
> "official" upstream dos2unix accept *for all platforms*.  It will not
> change upstream's behavior in any way, except for offering some new options.

01-avoid-hardlink-exist-error.patch
02-cygwin-defines-win32-but-isnt.patch
03-add--safe-option.patch
04-add-follow-no-follow--infile-only.patch
05-rationalize-logic-flow.patch
06-add-ResolveSymbolicLink-function.patch
07-support-follow-no-follow--outfile.patch
08-use-canonicalize-file-name-glibc24-cygwin17.patch

=== 01-avoid-hardlink-exist-error.patch
 Makefile |    2 ++
 1 file changed, 2 insertions(+)

=== 02-cygwin-defines-win32-but-isnt.patch
 dos2unix.c |   10 +++++-----
 unix2dos.c |   10 +++++-----
 2 files changed, 10 insertions(+), 10 deletions(-)

=== 03-add--safe-option.patch
 dos2unix.c |    3 +++
 unix2dos.c |    3 +++
 2 files changed, 6 insertions(+)

=== 04-add-follow-no-follow--infile-only.patch
 dos2unix.c |   25 ++++++++++++++++++++++---
 unix2dos.c |   25 ++++++++++++++++++++++---
 2 files changed, 44 insertions(+), 6 deletions(-)

=== 05-rationalize-logic-flow.patch
 dos2unix.c |   27 ++++++++++++++++-----------
 unix2dos.c |   27 ++++++++++++++++-----------
 2 files changed, 32 insertions(+), 22 deletions(-)

=== 06-add-ResolveSymbolicLink-function.patch
 dos2unix.c |   94 ++++++++++++++++++++++++++++++++++++++
 unix2dos.c |   94 ++++++++++++++++++++++++++++++++++++++
 2 files changed, 188 insertions(+)

=== 07-support-follow-no-follow--outfile.patch
 dos2unix.c |   72 +++++++++++++++++++++++++++++++++++++------
 unix2dos.c |   72 +++++++++++++++++++++++++++++++++++++------
 2 files changed, 132 insertions(+), 12 deletions(-)

=== 08-use-canonicalize-file-name-glibc24-cygwin17.patch
 dos2unix.c |   13 +++++++++++++
 unix2dos.c |   13 +++++++++++++
 2 files changed, 26 insertions(+)

Assuming they work (natch) I think these are suitable for upstream.

> The second one (#1, above), I'll propose that Erwin use as part of his
> initial cygwin package offering.  This one would be only a transitional
> measure, and would be slated to be dropped from a later cygwin package
> after a certain amount of time has passed.

=== dos2unix-5.2.1-1.src.patch
 dos2unix.c |    2 +-
 unix2dos.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Obviously, this one would eventually disappear, and would never go
"upstream".


Then, of course, there's the purely packaging related patch:

=== dos2unix-5.2.1-1.cygwin.patch
 dos2unix.README |   95 ++++++++++++++++++++++++++++++++++++
 setup.hint      |    7 ++++
 2 files changed, 102 insertions(+)

> With regards to the d2u/u2d aliases, for now I'd just modify the cygport
> script to create those as hardlinks, and not modify or patch the package
> source at all.

cygport script handles this.  So...

http://cygwin.cwilson.fastmail.fm/dos2unix-5.2.1-1-src.tar.bz2
http://cygwin.cwilson.fastmail.fm/dos2unix-5.2.1-1.tar.bz2

...but be warned...ZERO testing so far.

--
Chuck

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple