X-Recipient: archive-cygwin@delorie.com X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Message-ID: <4CAB42BA.2000303@cwilson.fastmail.fm> Date: Tue, 05 Oct 2010 11:22:34 -0400 From: Charles Wilson Reply-To: Charles Wilson User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9.2.9) Gecko/20100915 Thunderbird/3.1.4 MIME-Version: 1.0 To: cygwin@cygwin.com Subject: Re: rebaseall on [1.7] : first glitch for ages References: <4CAB15A6.1020007@bonhard.uklinux.net> <20101005130824.GA3224@tishler.net> <4CAB3208.701@cwilson.fastmail.fm> In-Reply-To: <4CAB3208.701@cwilson.fastmail.fm> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Delivered-To: mailing list cygwin@cygwin.com On 10/5/2010 10:11 AM, Charles Wilson wrote: > On 10/5/2010 9:08 AM, Jason Tishler wrote: >> rebase will skip some errors (e.g., when a DLL is not writable), but >> will exit if FixImage() fails. Maybe rebase should skip this error too? > > I don't think so -- what if the DLL was "partially" written, and some > other failure occurred? I'd want to know right away. FixImage should > probably, for now, just return without error if the image is 64bit. I realize that last sentence was unclear. What I meant was, FixImage() should check if the DLL is 64bit, and if so then *do nothing*, and return without error. OTOH, for 32bit DLLs, FixImage() should retain its current behavior of returning WITH error if anything goes wrong. At least, until rebase gains the ability to act on 64bit DLLs. -- Chuck -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple