X-Recipient: archive-cygwin@delorie.com X-Spam-Check-By: sourceware.org Date: Tue, 17 Aug 2010 11:08:16 +0200 From: Corinna Vinschen To: cygwin@cygwin.com Subject: Re: diff /usr/include/endian.orig.h /usr/include/endian.h > endian.h.diff Message-ID: <20100817090816.GB16404@calimero.vinschen.de> Reply-To: cygwin@cygwin.com Mail-Followup-To: cygwin@cygwin.com References: <20100812225838.GB15724@ednor.casa.cgf.cx> <4C647D32.1090907@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Delivered-To: mailing list cygwin@cygwin.com Pedro, first of all, did you read http://cygwin.com/contrib.html? Especially the "Before you get started" section. For this patch, given that it is just a bunch of rather obvious defines, I don't think we have to treat the patch as significant. However, please don't use _BSD_SOURCE. The newlib/Cygwin headers are not set up like the Linux headers and the big bunch of definitions from /usr/include/features.h are not available so far. The _BSD_SOURCE define is not honored or set anywhere right now. What you can do is to use _POSIX_SOURCE. So, if you're going to use #ifndef _POSIX_SOURCE instead, and if you're creating a ChangeLog entry in the correct ChangeLog entry format (see the ChangeLog file), then I guess we can check it in. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Project Co-Leader cygwin AT cygwin DOT com Red Hat -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple