X-Recipient: archive-cygwin@delorie.com X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Subject: RE: [ATTN: cvs maintainer] trailing dot issue with cygwin 1.7 Date: Tue, 6 Apr 2010 10:01:14 -0400 Message-ID: In-Reply-To: <4BBAA157.40307@cwilson.fastmail.fm> From: To: , X-EMM-EM: Active X-IsSubscribed: yes Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Delivered-To: mailing list cygwin@cygwin.com If you're going to tack on a character at the end, shorten the length from 9 to 8. I believe the goal is to keep the resulting string to 14 characters. Most likely this is to be compliant with _POSIX_NAME_MAX, which in limits.h is 14. - doug -----Original Message----- From: cygwin-owner@cygwin.com [mailto:cygwin-owner@cygwin.com] On Behalf Of Charles Wilson Sent: Monday, April 05, 2010 10:50 PM To: cygwin@cygwin.com Subject: Re: [ATTN: cvs maintainer] trailing dot issue with cygwin 1.7 On 4/4/2010 11:01 AM, crosmun_william@emc.com wrote: > The _POSIX_NO_TRUNC variable is defined in cygwin 1.7, and not defined in cygwin 1.5, so in cygwin 1.7, the code goes down the path where the temp_filename is the first 9 characters of the original filename preceded by '.new.' The problem occurs when the 9th character in the filename is a dot. Eg, 'abcdefgh.txt'. The temp_filename becomes '.new.abcdefgh.' Unfortunately, when checking out to a Samba share, or other network shares that try to be CIFS compatible, a trailing . is invalid in a filename. The temporary file either doesn't get created, or gets created but with the trailing dot truncated. The checkout then fails with 'file not found' errors.=20 >=20 > A simple fix would be to add a valid character after the .9s, eg >=20 > sprintf (temp_filename, ".new.%.9s~", filename);=20 >=20 > Can something like this be done and a new package released? Thanks for the report and suggestion. I'll include a suitable change in the next release, but it may be a few weeks before I can get to that. -- Chuck -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple