X-Recipient: archive-cygwin@delorie.com
X-Spam-Check-By: sourceware.org
Date: Wed, 23 Sep 2009 11:22:09 +0200
From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin@cygwin.com
Subject: Re: [1.7] rename/renameat error
Message-ID: <20090923092209.GX20981@calimero.vinschen.de>
Reply-To: cygwin@cygwin.com
Mail-Followup-To: cygwin@cygwin.com
References: <4AA52B5E.8060509@byu.net> <20090907192046.GA12492@calimero.vinschen.de> <loom.20090909T005422-847@post.gmane.org> <loom.20090909T183010-83@post.gmane.org> <loom.20090922T225033-801@post.gmane.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <loom.20090922T225033-801@post.gmane.org>
User-Agent: Mutt/1.5.19 (2009-02-20)
Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm
Precedence: bulk
List-Id: <cygwin.cygwin.com>
List-Unsubscribe: <mailto:cygwin-unsubscribe-archive-cygwin=delorie.com@cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe@cygwin.com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin@cygwin.com>
List-Help: <mailto:cygwin-help@cygwin.com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner@cygwin.com
Mail-Followup-To: cygwin@cygwin.com
Delivered-To: mailing list cygwin@cygwin.com

On Sep 22 21:02, Eric Blake wrote:
> Eric Blake <ebb9 <at> byu.net> writes:
> 
> > > > > Cygwin 1.7 is
> > > > > detecting this situation (which is a step up from 1.5 which did the 
> rename
> > > > > anyways), but sets errno to EBUSY instead of EINVAL.
> > > > 
> > > > Thanks for catching.  Feel free to fix the rename function accordingly.
> > > 
> > > OK, I'll look into it (I don't know how large the patch will be, yet).
> > 
> > And link("a","f/.") should not create "f" as a regular file, either.  I'm 
> still 
> > looking at where to patch things.
> 
> I've got a patch in testing for both of these issues.  But while looking at 
> path.cc, I've noticed a couple of things:
> 
> The code doesn't do a very good job of remembering lengths it has already 
> seen.  For example, with relative paths, the code in normalize_posix_path does 
> cwd.get, then strchr; it seems like since cwd.get already knows how many bytes 
> it copied, that a simple API modification would pass that information back to 
> the caller so that the caller doesn't have to use strchr to find the end of the 
> string.  Anything we can do to avoid rescanning strings of known length will 
> provide speedups in path handling.

This one might be worth a shot, if it's an easy patch.

> I'm also wondering whether it is time to finally emulate Linux by requiring 
> that when doing pathname resolution of 'a/..', that 'a' actually exist (either 
> as a directory or a symlink to directory), instead of silently ignoring that 
> part of the string.  Should I go ahead and spend time working up a patch for 
> this?

This is something which I have on my TODO list for a long time, but I
never saw a simple way to implement this without losing a lot of the
already lousy performance of the path conversion.  Additionally the path
conversion code is already quite complicated and I fear the unwanted
side effects such a change could have.  Therefore, I tend to think of
this as a welcome post-1.7.1 change.


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple