X-Recipient: archive-cygwin@delorie.com
X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 	tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS
X-Spam-Check-By: sourceware.org
To: cygwin@cygwin.com
From: Eric Blake <ebb9@byu.net>
Subject:  Re: [1.7] rename/renameat error
Date: Tue, 8 Sep 2009 22:55:31 +0000 (UTC)
Lines: 23
Message-ID:  <loom.20090909T005422-847@post.gmane.org>
References:  <4AA52B5E.8060509@byu.net> <20090907192046.GA12492@calimero.vinschen.de>
Mime-Version:  1.0
Content-Type:  text/plain; charset=us-ascii
Content-Transfer-Encoding:  7bit
User-Agent: Loom/3.14 (http://gmane.org/)
X-IsSubscribed: yes
Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm
List-Id: <cygwin.cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe@cygwin.com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin@cygwin.com>
List-Help: <mailto:cygwin-help@cygwin.com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner@cygwin.com
Mail-Followup-To: cygwin@cygwin.com
Delivered-To: mailing list cygwin@cygwin.com

Corinna Vinschen <corinna-cygwin <at> cygwin.com> writes:

> > POSIX states that rename must fail with EINVAL if either argument ends in
> > '.' or '..' (after trailing slashes are stripped).  Cygwin 1.7 is
> > detecting this situation (which is a step up from 1.5 which did the rename
> > anyways), but sets errno to EBUSY instead of EINVAL.
> 
> Thanks for catching.  Feel free to fix the rename function accordingly.

OK, I'll look into it (I don't know how large the patch will be, yet).

> This falls definitely under the trivial patch rule.

Trivial or not, I won't commit it until the copyright papers are final (I've 
made enough "trivial" contributions over the years to add up to a non-trivial 
sum total).  But the good news: I finally got my employer to sign forms today, 
so the only delay now is for the postal service.  Let's see, now, how long 
since you first asked me to fill out forms?

-- 
Eric Blake




--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple