X-Recipient: archive-cygwin@delorie.com X-Spam-Check-By: sourceware.org Date: Thu, 20 Aug 2009 11:16:03 -0400 From: Christopher Faylor To: cygwin@cygwin.com Subject: Re: find(1) memory leak in cygheap Message-ID: <20090820151603.GB13716@ednor.casa.cgf.cx> Reply-To: cygwin@cygwin.com Mail-Followup-To: cygwin@cygwin.com References: <20090819140322.GB8713@ednor.casa.cgf.cx> <20090820083926.GJ32408@calimero.vinschen.de> <4A8D396D.8000209@gmail.com> <4A8D3EFD.9080704@sbcglobal.net> <4A8D6558.8080404@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4A8D6558.8080404@gmail.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Delivered-To: mailing list cygwin@cygwin.com On Thu, Aug 20, 2009 at 04:01:44PM +0100, Dave Korn wrote: >Greg Chicares wrote: >> On 2009-08-20 11:54Z, Dave Korn wrote: >>> [...] (Hmm, now there's an idea. GCC needs an >>> __attribute__ that you can tag onto a class to say it must be a POD-type and >>> get a compiler error if anyone ever adds a virtual function or anything else >>> that would make the layout non-POD.) >> >> http://groups.google.com/group/comp.lang.c++.moderated/msg/71ae531aa27e70c5 >> | GCC 4.3.1 provides the __is_pod extension >> ... >> | tr1/type_traits is implemented using __is_pod >> >> Combining that with static_assert, I suppose you could write >> this restriction in standard C++ (TR1) instead of creating a >> new __attribute__. > > Ooh, nice trick. Thanks. We should probably consider removing the memcpy's from the path_conv and fhandler_base classes for 1.7.1. I started to do that this morning but realized that this wasn't something for 1.7.0. cgf -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple