X-Spam-Check-By: sourceware.org Date: Fri, 19 Jan 2007 18:27:40 +0100 From: Corinna Vinschen To: cygwin@cygwin.com Subject: Re: 1.7.0 CVS mmap failure Message-ID: <20070119172740.GJ27843@calimero.vinschen.de> Reply-To: cygwin@cygwin.com Mail-Followup-To: cygwin@cygwin.com References: <20070105192302.GD12776@calimero.vinschen.de> <20070110095345.GL23638@calimero.vinschen.de> <20070117103959.GA23172@calimero.vinschen.de> <20070118091400.GC27843@calimero.vinschen.de> <20070118171852.GA18119@calimero.vinschen.de> <20070119154125.GD1586@ns1.anodized.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070119154125.GD1586@ns1.anodized.com> User-Agent: Mutt/1.4.2.2i Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Delivered-To: mailing list cygwin@cygwin.com On Jan 19 07:41, Christopher Layne wrote: > Thanks for fixing this. I also noticed these when reading through the code. > Another area for extremely small optimization is to just cache the pagesize. > I notice a *lot* of calls to getpagesize(), when I can't really see the > pagesize changing within a single call to mmap(). Since the map implementations See the implementation of getpagesize. It's only evaluated once, the function is used as encapsulation. I don't think you will see a really noticable performance gain by storing the result in a local var. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Project Co-Leader cygwin AT cygwin DOT com Red Hat -- Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple Problem reports: http://cygwin.com/problems.html Documentation: http://cygwin.com/docs.html FAQ: http://cygwin.com/faq/