X-Spam-Check-By: sourceware.org
Date: Sun, 26 Mar 2006 15:09:59 -0500 (EST)
From: Igor Peshansky <pechtcha@cs.nyu.edu>
Reply-To: cygwin@cygwin.com
To: cygwin@cygwin.com
Subject: Re: ":" in filename
In-Reply-To: <4425916C.9040009@cygwin.com>
Message-ID: <Pine.GSO.4.63.0603261508220.4022@access1.cims.nyu.edu>
References: <8389af8b0603241937m62e9701y596bed40382bd6f0@mail.gmail.com>  <4424BE59.9184F1E1@dessent.net> <4424C1DC.8010005@byu.net> <4425916C.9040009@cygwin.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:cygwin-unsubscribe-archive-cygwin=delorie.com@cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe@cygwin.com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin@cygwin.com>
List-Help: <mailto:cygwin-help@cygwin.com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner@cygwin.com
Mail-Followup-To: cygwin@cygwin.com
Delivered-To: mailing list cygwin@cygwin.com

On Sat, 25 Mar 2006, Larry Hall (Cygwin) wrote:

> Eric Blake wrote:
>
> <snip>
>
> > It would be nice if cygwin could be more proactive in recognizing : as
> > invalid in non-managed mounts, rather than passing the : on to the
> > Windows filename functions, in order to avoid the creation of
> > undeletable filenames such as ".new." via the help of a colon, but I
> > can live with the current behavior if adding such a check would slow
> > down the common case.
>
> The latter affect is certainly the case here though, as usual, I'm sure
> it's a PTC if someone has a great brainstorm for a way to do this
> without the overhead.

Well, normalize_posix_path() (in path.cc) already scans the whole path
string looking for '\\' -- I can't imagine that adding a check for ':'
would introduce all that much overhead.  But, of course, empirical
evidence is always best, and I don't have any at the moment.

Eric, care to simply add a test for ':' in that loop and do some
measurements?
	Igor
-- 
				http://cs.nyu.edu/~pechtcha/
      |\      _,,,---,,_	    pechtcha@cs.nyu.edu | igor@watson.ibm.com
ZZZzz /,`.-'`'    -.  ;-;;,_		Igor Peshansky, Ph.D. (name changed!)
     |,4-  ) )-,_. ,\ (  `'-'		old name: Igor Pechtchanski
    '---''(_/--'  `-'\_) fL	a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

"Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte."
"But no -- you are no fool; you call yourself a fool, there's proof enough in
that!" -- Rostand, "Cyrano de Bergerac"

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/