X-Spam-Check-By: sourceware.org Date: Thu, 5 Jan 2006 21:55:31 -0500 From: Christopher Faylor To: cygwin@cygwin.com Subject: Re: services not starting with 20060104 snapshot Message-ID: <20060106025531.GG1937@trixie.casa.cgf.cx> Reply-To: cygwin@cygwin.com References: <20060105203241.GA26305@trixie.casa.cgf.cx> <43BDB8B0.8070600@cygwin.com> <20060106005917.GA1937@trixie.casa.cgf.cx> <43BDC7E5.1070809@cygwin.com> <20060106015259.GC1937@trixie.casa.cgf.cx> <43BDCFCC.2090305@cygwin.com> <20060106023407.GE1937@trixie.casa.cgf.cx> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060106023407.GE1937@trixie.casa.cgf.cx> User-Agent: Mutt/1.5.11 Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Delivered-To: mailing list cygwin@cygwin.com On Thu, Jan 05, 2006 at 09:34:07PM -0500, Christopher Faylor wrote: >That was supposed to fix the problem of console windows appearing when the >service is allowed to interact with the desktop. Does this do anything, Larry? cgf Index: fhandler_console.cc =================================================================== RCS file: /cvs/uberbaum/winsup/cygwin/fhandler_console.cc,v retrieving revision 1.155 diff -u -p -r1.155 fhandler_console.cc --- fhandler_console.cc 5 Jan 2006 16:26:22 -0000 1.155 +++ fhandler_console.cc 6 Jan 2006 02:54:56 -0000 @@ -146,7 +146,7 @@ tty_list::get_tty (int n) void __stdcall set_console_state_for_spawn (bool noncygwin_process) { - if (noncygwin_process && fhandler_console::need_invisible ()) + if ((1 || noncygwin_process) && fhandler_console::need_invisible ()) return; HANDLE h = CreateFile ("CONIN$", GENERIC_READ, FILE_SHARE_WRITE, @@ -1825,6 +1825,9 @@ fhandler_console::fixup_after_fork_exec bool NO_COPY fhandler_console::invisible_console; +// #define WINSTA_ACCESS (WINSTA_READATTRIBUTES | STANDARD_RIGHTS_READ | STANDARD_RIGHTS_WRITE | WINSTA_CREATEDESKTOP | WINSTA_EXITWINDOWS) +#define WINSTA_ACCESS STANDARD_RIGHTS_READ + bool fhandler_console::need_invisible () { @@ -1856,9 +1859,8 @@ fhandler_console::need_invisible () h = horig = GetProcessWindowStation (); if (myself->ctty == -1) { - if (!(h = CreateWindowStation (NULL, 0, WINSTA_ALL_ACCESS, &sec_all_nih))) - h = CreateWindowStation ("CygwinInvisible", 0, WINSTA_ALL_ACCESS, - &sec_all_nih); + if (!(h = CreateWindowStation (NULL, 0, WINSTA_ACCESS, NULL))) + h = CreateWindowStation ("CygwinInvisible", 0, WINSTA_ACCESS, NULL); termios_printf ("CreateWindowStation(\"CygwinInvisible\", %p), %E", h); if (h) { -- Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple Problem reports: http://cygwin.com/problems.html Documentation: http://cygwin.com/docs.html FAQ: http://cygwin.com/faq/