X-Spam-Check-By: sourceware.org Date: Tue, 6 Dec 2005 22:01:45 -0500 (EST) From: Igor Pechtchanski Reply-To: cygwin@cygwin.com To: cygwin@cygwin.com Subject: Re: [PATCH] cygcheck bug when listing services In-Reply-To: <20051207014747.GC15641@trixie.casa.cgf.cx> Message-ID: References: <5a97ceb0512042223i404ebffeuff5546e2345df965@mail.gmail.com> <20051207000050.GB5452@efn.org> <20051207014747.GC15641@trixie.casa.cgf.cx> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Delivered-To: mailing list cygwin@cygwin.com On Tue, 6 Dec 2005, Christopher Faylor wrote: > On Tue, Dec 06, 2005 at 08:41:24PM -0500, Igor Pechtchanski wrote: > >On Tue, 6 Dec 2005, Yitzchak Scott-Thoennes wrote: > >[snip] > >> That needs a comment in the code. > > > >Fair enough: > >[snip] > >+ /* Add two nulls to avoid confusing strtok() when the trailing separator > >+ is missing */ > > How about a testcase which shows that the MSVCRT strtok needs two > trailing NUL bytes to work around problems when there is no trailing > separator? I would find that much more interesting than a comment which > simply asserts that behavior. Fair enough. The double-null issue was a red herring, apparently -- a simple recompile fixed the problem. In fact, the cygcheck from the latest snapshot doesn't exhibit this behavior. Patch withdrawn. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_ pechtcha@cs.nyu.edu ZZZzz /,`.-'`' -. ;-;;,_ igor@watson.ibm.com |,4- ) )-,_. ,\ ( `'-' Igor Pechtchanski, Ph.D. '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! If there's any real truth it's that the entire multidimensional infinity of the Universe is almost certainly being run by a bunch of maniacs. /DA -- Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple Problem reports: http://cygwin.com/problems.html Documentation: http://cygwin.com/docs.html FAQ: http://cygwin.com/faq/