Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner@cygwin.com Mail-Followup-To: cygwin@cygwin.com Delivered-To: mailing list cygwin@cygwin.com Date: Wed, 11 May 2005 16:49:52 -0700 From: David Rothenberger Subject: Re: Fixing strace and cygcheck so that they work with mount -X In-reply-to: <42828A27.5050206@mscha.org> To: cygwin@cygwin.com Message-id: <42829A20.2030209@acm.org> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit References: <20050508230637.GD3896@trixie.casa.cgf.cx> <20050509002126.GH3896@trixie.casa.cgf.cx> <20050509022611.GA7850@trixie.casa.cgf.cx> <427F9C41.1000605@acm.org> <427FB7B2.8040903@mscha.nl> <20050510151746.GV15665@trixie.casa.cgf.cx> <42822503.2090903@mscha.org> <20050511154036.GD10119@trixie.casa.cgf.cx> <20050511165354.GA15412@trixie.casa.cgf.cx> <428255DA.4030907@acm.org> <42828A27.5050206@mscha.org> User-Agent: Mozilla Thunderbird 1.0.2 (Windows/20050317) X-IsSubscribed: yes Reply-To: cygwin@cygwin.com On 5/11/2005 3:41 PM, Michael Schaap wrote: > The patch as-is doesn't compile for me, though, I presume because > char **envp = (char **) cygwin_internal (CW_ENVP); > uses a not-yet-released Cygwin enhancement. But when I change it to the > simpler and more standard > char **envp = environ; > it compiles and works fine, both under mount -X and normally. Doh! I didn't read Chris' last comment carefully enough. Yes, copying from environ is much more reasonable. > (At first I was a bit suspicious of the logic - it only sets those > Windows variables that are not currently set, so what about variables > that were changed or deleted within Cygwin? - but it looks like the > Windows environment isn't the standard pre-Cygwin user environment, but > a minimal one with only PATH and SYSTEMROOT set, so it actually does > behave optimally this way - it sets all other variables when running > under mount -X, and sets nothing otherwise.) Right. The main reason I did that, though, was because copying the Cygwin PATH to the Windows environment caused lots of core dumps. > Revised patch attached. Can you try this out and see if it still works > for you? If you confirm this, I'll resend the patch in a new, more > obviously titled thread, to attract Chuck's attention. ;-) Works fine for me. Start attracting! -- David Rothenberger spammer? -> spam@daveroth.dyndns.org GPG/PGP: 0x7F67E734, C233 365A 25EF 2C5F C8E1 43DF B44F BA26 7F67 E734 To Perl, or not to Perl, that is the kvetching. -- Larry Wall in <199801200310.TAA11670@wall.org> -- Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple Problem reports: http://cygwin.com/problems.html Documentation: http://cygwin.com/docs.html FAQ: http://cygwin.com/faq/